Port new VTX API and settings from Betaflight #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiam
force-pushed
the
agh_vtx_settings
branch
2 times, most recently
from
4d7db4a
to
c873dcf
Compare
- VTX with support for FC control are now totally managed from the FC. The FC will store the VTX configuration and override any changes made manually (e.g. with a button). Users can disable VTX control to manage channels manually. - OSD VTX item now shows the power level too. - Added new parameters for VTX configuration: vtx_band, vtx_channel, vtx_freq, vtx_halfduplex, vtx_low_power_disarm, vtx_pit_mode_freq and vtx_power. - Added support for automatically switching the VTX power when arming (fixes #3112). Note that there are a several changes from the BF code. We do support an additional setting for the low power during disarm option and the MSP messages contain more data to allow users to configure the VTX channel/power from the configurator. Our MSP messages also work when the VTX is offline (the settings are stored in the FC and applied later once the VTX is powered up). Thanks to Matek (http://www.mateksys.com) for providing an FCHUB-VTX to test the Tramp protocol. Thanks to AKK (https://www.akktek.com) for providing an X2-ultimate to test SmartAudio.
mikeller
reviewed
Jun 23, 2018
| uint8_t band=0, channel=0; | ||
| vtxCommonGetBandAndChannel(&band,&channel); | ||
| uint8_t deviceType = 0; | ||
| vtxCommonGetDeviceType(vtxDevice); |
There was a problem hiding this comment.
This doesn't actually do anything.
There was a problem hiding this comment.
Nice catch. Thanks! It worked by chance because the configurator only checks for deviceType != 0xff and this was writing a zero. I’ll PR a fix tomorrow.
mikeller
reviewed
Jun 23, 2018
| sbufWriteU8(dst, pitmode); | ||
|
|
||
| // Betaflight doesn't send these fields |
There was a problem hiding this comment.
This is outdated: betaflight/betaflight#6200 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FC. The FC will store the VTX configuration and override any changes
made manually (e.g. with a button). Users can disable VTX control
to manage channels manually.
vtx_freq, vtx_halfduplex, vtx_low_power_disarm, vtx_pit_mode_freq
and vtx_power.
arming (fixes Feature request: Auto vtx power low on disarm #3112).
Note that there are a several changes from the BF code. We do support
an additional setting for the low power during disarm option and
the MSP messages contain more data to allow users to configure the
VTX channel/power from the configurator. Our MSP messages also work
when the VTX is offline (the settings are stored in the FC and applied
later once the VTX is powered up).
Thanks to Matek (http://www.mateksys.com) for providing an FCHUB-VTX
to test the Tramp protocol.
Thanks to AKK (https://www.akktek.com) for providing an X2-ultimate
to test SmartAudio.
Configurator PR iNavFlight/inav-configurator#481