Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional MSP-based sensors #6090

Merged
merged 6 commits into from Nov 7, 2020
Merged

Add additional MSP-based sensors #6090

merged 6 commits into from Nov 7, 2020

Conversation

digitalentity
Copy link
Member

@digitalentity digitalentity commented Sep 2, 2020 •
edited

Required to support AP_Periph-based sensors (i.e. a new CAN-GPS from @MATEKSYS)

  • GPS
  • Barometer
  • Compass/magnetometer

@digitalentity digitalentity added Don't merge Release Notes Add this when a PR needs to be mentioned in the release notes labels Sep 2, 2020
@digitalentity digitalentity added this to the 2.6 milestone Sep 2, 2020
@digitalentity digitalentity self-assigned this Sep 2, 2020
@digitalentity
Copy link
Member Author

@tridge - FYI to keep things aligned with AP_Periph

@digitalentity digitalentity marked this pull request as draft September 2, 2020 13:54
tridge
tridge suggested changes Sep 3, 2020
View reviewed changes
src/main/io/gps_msp.c Outdated Show resolved Hide resolved
src/main/io/gps_msp.c Outdated Show resolved Hide resolved
src/main/io/gps_msp.c Outdated Show resolved Hide resolved
@tridge tridge mentioned this pull request Sep 3, 2020
Closed
tridge
tridge suggested changes Sep 3, 2020
View reviewed changes
src/main/io/gps_msp.c Show resolved Hide resolved
src/main/io/gps_msp.c Outdated Show resolved Hide resolved
@tridge
Copy link

tridge commented Sep 3, 2020

I think we should add a uint8_t instance number to all sensors, so we can support dual GPS, mag, baro etc in the future.

@yaapu yaapu mentioned this pull request Sep 3, 2020
Merged
@digitalentity
Copy link
Member Author

Added week and instance fields. Also fixed a bug with newData not being reset and causing 50Hz false update rate.

@digitalentity
Copy link
Member Author

Tested baro, compass and GPS - all working. Compass default alignment is now hardcoded in the driver so it's CW0 rotation for the user.

@digitalentity digitalentity marked this pull request as ready for review September 8, 2020 09:47
@digitalentity digitalentity mentioned this pull request Sep 8, 2020
Merged
@digitalentity
Copy link
Member Author

Configurator support PR iNavFlight/inav-configurator#1062

@giacomo892
Copy link
Collaborator

@digitalentity I think we should add an MSP airspeed driver too.
MATEK units have an I2C port specifically for an airspeed sensors and the support for them would render MSP complete as much as CAN.
Toughts?

@giacomo892 giacomo892 mentioned this pull request Oct 24, 2020
Merged
@digitalentity digitalentity merged commit bb7dd60 into master Nov 7, 2020
@digitalentity digitalentity mentioned this pull request Nov 14, 2020
Closed
@digitalentity digitalentity deleted the de_extra_msp_sensors branch November 15, 2020 08:48
@kafie1980 kafie1980 mentioned this pull request Jun 18, 2021
Open
@robustini
Copy link

@digitalentity please read here, also my comments at the end:: #7576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge requested changes

Assignees

@digitalentity digitalentity

Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@digitalentity @tridge @giacomo892 @robustini