Add ability to adjust LED Strip color with RC channel #7618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DzikuVx
approved these changes
Nov 22, 2021
|
Got a notice that this will be closed in two weeks if no activity occurs with it |
|
No, not this one. StaleBot has not touched this one |
|
closes #4481 |
|
@jeffhendrix as it's time to start merging, I have a question. Do we need a Configurator support for this one? |
|
Not needed, but makes it easier to configure.
Here is the PR for configurator changes
iNavFlight/inav-configurator#1406
…On Tue, Feb 22, 2022 at 6:19 AM Paweł Spychalski ***@***.***> wrote:
@jeffhendrix <https://github.com/jeffhendrix> as it's time to start
merging, I have a question. Do we need a Configurator support for this one?
—
Reply to this email directly, view it on GitHub
<#7618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVNCLVTUOTZZYA5NLTYWDDU4OEN7ANCNFSM5IM47SPA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
DzikuVx
requested changes
Feb 23, 2022
There was a problem hiding this comment.
@jeffhendrix one final request, we have to bump parameter group version in src/main/io/ledstrip.c on line 76
The config structure changes so version has to change as well
DzikuVx
added
the
Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to adjust LED Strip color with RC channel by using H in led cli (see LedStrip.md)
closes #7556