Re-order boxmodes to have as little disruption to 5.1 as possible #8394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrD-RC
added
the
Release Notes
|
Do you remember my proposal to change the box number in the diff, by the name of the flight mode? This model of mine would certainly avoid this kind of thing... But unfortunately it makes F722 targets crash (despite working 100% on the F405)... I still have the algorithm in my fork. |
JulioCesarMatias
approved these changes
Sep 14, 2022
|
Yes @JulioCesarMatias I remember that. It's a shame it didn't work with F722. From what I remember, it worked fine with F411 too. So it wasn't a memory problem. |
MrD-RC
removed
the
Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8346 corrected an error in the boxmodes with a shared ID for USER3. However, in that change, 7 modes were unnecessarily reordered. This would cause issues when restoring diffs, as at least two of those modes are used frequently on fixed wing, and another two on multi-rotor. One mode will still need to be moved. Loiter direction change likely has the least usage, so would effect the least number of people.
Note: Boxmode numbering fixed in #8401. So no changes between 5.1 and 6.0 for existing boxmodes.