Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PINIO 3 & 4 plus MATEKF722PX_PINIO target #8401

Merged

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Sep 17, 2022

There are plenty of flight controllers around now that use PINIO 1 and 2 internally for camera switching and switchable VTx power. This left no scope for user definable PINIO. A friend wanted to control a Caddx Peanut on such an FC. So I have implemented USER 3 and USER 4 PINIO options. Also in the PR is the target that was created for my friend. Said target works like a charm.

When rebasing to 6.0 master, I initially worked on 5.1.0 base, I saw that shellixyz had added USER 3 to master. But It had a box mode ID conflict. I fixed the initial problems with PR #8276, which negates the need for fixes #8346 and #8394. As USER 3 is not yet in a release (no milestone), changing the box ID for that makes the most sense. Due to this, no current box modes are disrupted at all. All diffs will work fine from 5.x to 6.x as far as box modes are concerned.

This will require a small Configurator update to correct the ordering on the modes page and add support for the LCs. iNavFlight/inav-configurator#1621

There are plenty of flight controllers around now that use PINIO 1 and 2 internally for camera switching and switchable VTx power. This left no scope for user definable PINIO. A friend wanted to control a Caddx Peanut on such an FC. So I have implemented USER 3 and USER 4 PINIO options. Also in the PR is the target that was created for my friend.
@MrD-RC MrD-RC added this to the 6.0 milestone Sep 17, 2022
Copy link
Collaborator

@JulioCesarMatias JulioCesarMatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrD-RC MrD-RC requested a review from DzikuVx September 30, 2022 18:55
- Corrected BOXID for Change Mission
- Added 2nd PINIO (USER 4) to UART of F722-PX
@MrD-RC MrD-RC merged commit 37c6434 into master Nov 15, 2022
@MrD-RC MrD-RC deleted the MrD_Add-USER-3-and-USER-4-PINIO-Also-MATEKF722PX_PINIO-target branch November 15, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants