Add label to examples #1421
Merged
Add label to examples #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarov
force-pushed
the
add-label-to-examples
branch
from
50f3894
to
9843fb3
Compare
gchoqueux
reviewed
Jun 22, 2020
src/Core/Style.js
Outdated
|
|
||
| if (properties.icon && properties.icon.startsWith('data:')) { | ||
| this.icon = { dom: getImageFromDataURL(properties.icon) }; | ||
| this.icon.dom.onload = () => { |
There was a problem hiding this comment.
could factorize with loading pattern?
zarov
force-pushed
the
add-label-to-examples
branch
2 times, most recently
from
dd7717d
to
634729a
Compare
The Mapbox library has not been maintained for almost 3 years, and this fork (@tmcw/togeojson) is better to used. See the repo itself: https://github.com/tmcw/togeojson
zarov
force-pushed
the
add-label-to-examples
branch
from
634729a
to
fac67b9
Compare
gchoqueux
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels have been added in some examples, to show that they work with multiple format:
I also took the opportunity to move from
@mapbox/togeojsonto@tmcw/togeojson, as it is more up-to-date.This is a replacement for #1413