[OGC3DTiles] Add support for picking #2364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desplandis
changed the title
Desplandis
force-pushed
the
ogc3dtiles/picking
branch
from
5ff1a30
to
061776d
Compare
Desplandis
force-pushed
the
ogc3dtiles/picking
branch
from
061776d
to
76b230c
Compare
jailln
reviewed
Jul 19, 2024
Desplandis
force-pushed
the
ogc3dtiles/picking
branch
from
76b230c
to
3db60ba
Compare
|
Rebased on #2365 |
jailln
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add support for picking on new
OGC3DTilesLayer. It is compatible with the old interface ofC3DTilesLayerexcept thatgetC3DTileFeatureFromIntersectsArrays(please rename this 40 chars method name...) now returns an object containing features for the closest intersection instead of an oldC3DTilesFeatureinstance.This PR also add picking for points data, which was not supported on the old implementation (you could try it live with
3dtiles_pointcloudexample).Note that we are waiting for NASA-AMMOS/3DTilesRendererJS#627 to be merged and new version of
3d-tiles-rendererbefore merging this PR. =)