3d tiles migration clean #2365
Merged
3d tiles migration clean #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desplandis
approved these changes
Jul 19, 2024
src/Layer/OGC3DTilesLayer.js
Outdated
| @@ -10,6 +10,50 @@ import ReferLayerProperties from 'Layer/ReferencingLayerProperties'; | |||
| // Internal instance of GLTFLoader, passed to 3d-tiles-renderer-js to support GLTF 1.0 and 2.0 | |||
| // Temporary exported to be used in deprecated B3dmParser | |||
| export const itownsGLTFLoader = new iGLTFLoader(); | |||
| // TODO: waiting for https://github.com/NASA-AMMOS/3DTilesRendererJS/pull/626 to be merged to enable this extension | |||
There was a problem hiding this comment.
Merged, waiting for a release.
Suggested change
| // TODO: waiting for https://github.com/NASA-AMMOS/3DTilesRendererJS/pull/626 to be merged to enable this extension |
| * @event OGC3DTilesLayer#load-model | ||
| * @type {Object} | ||
| * @property {THREE.Group} scene - the model (tile content) parsed in a THREE.GROUP | ||
| * @property {Object} tile - the tile metadata from the tileset |
There was a problem hiding this comment.
Suggested change
| * @property {Object} tile - the tile metadata from the tileset | |
| * @property {Tile} tile - the tile metadata from the tileset |
There was a problem hiding this comment.
There is no Tile class, I sticked with Object
| * @event OGC3DTilesLayer#dispose-model | ||
| * @type {Object} | ||
| * @property {THREE.Group} scene - the model (tile content) that is disposed | ||
| * @property {Object} tile - the tile metadata from the tileset |
There was a problem hiding this comment.
Suggested change
| * @property {Object} tile - the tile metadata from the tileset | |
| * @property {Tile} tile - the tile metadata from the tileset |
| * @event OGC3DTilesLayer#tile-visibility-change | ||
| * @type {Object} | ||
| * @property {THREE.Group} scene - the model (tile content) parsed in a THREE.GROUP | ||
| * @property {Object} tile - the tile metadata from the tileset |
There was a problem hiding this comment.
Suggested change
| * @property {Object} tile - the tile metadata from the tileset | |
| * @property {Tile} tile - the tile metadata from the tileset |
| * @type {Object} | ||
| * @property {THREE.Group} scene - the model (tile content) parsed in a THREE.GROUP | ||
| * @property {Object} tile - the tile metadata from the tileset | ||
| */ |
There was a problem hiding this comment.
Missing parameter in event.
Suggested change
| */ | |
| * @property {boolean} visible - the tile visible state | |
| */ |
Comment on lines
+154
to
+170
| _setupCacheAndQueues() { | ||
| if (lruCache === null) { | ||
| lruCache = this.tilesRenderer.lruCache; | ||
| } else { | ||
| this.tilesRenderer.lruCache = lruCache; | ||
| } | ||
| if (downloadQueue === null) { | ||
| downloadQueue = this.tilesRenderer.downloadQueue; | ||
| } else { | ||
| this.tilesRenderer.downloadQueue = downloadQueue; | ||
| } | ||
| if (parseQueue === null) { | ||
| parseQueue = this.tilesRenderer.parseQueue; | ||
| } else { | ||
| this.tilesRenderer.parseQueue = parseQueue; | ||
| } | ||
| } |
There was a problem hiding this comment.
Just a suggestion. You could add lruCache, downloadQueue and parseQueue in a single object and only do a single null check?
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OGC3DTilesLayerOGC3DtilesLayer