Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (3dtiles): fix SSE computation #459

Merged
merged 1 commit into from
Aug 29, 2017
Merged

fix (3dtiles): fix SSE computation #459

merged 1 commit into from
Aug 29, 2017

Conversation

NikoSaul
Copy link
Contributor

Use distance to bounding volume instead of distance to center of the bounding volume
Issue: #185

Use distance to bounding volume instead of distance to center of the bounding volume
Issue: #185
@nguyenign
Copy link

It seems to me that it continues to download all the tiles!

@NikoSaul
Copy link
Contributor Author

Can you give me your tileset.json please?
Else this PR doesn't fix all problems for the issue #185 but just the sse.

@nguyenign
Copy link

you can find the download link in this issue, but if it's not enough i can send you a bigger 3dtiles.

@Jeremy-Gaillard
Copy link
Contributor

Your problem isn't really a bug. We tried making your tileset work and we identified two issues:

  • Missing refine: "ADD fields in some of the tiles
  • The SSE refinement threshold is much higher in Cesium (16 by default, compared to 1 in iTowns)

So it works properly, it's just that the building disappear only when you're very far away.

We will make a PR to change the SSE threshold and make it customisable.

@nguyenign
Copy link

nguyenign commented Aug 29, 2017

  • We need to define only one time refine, then it's optional!

"The refine property is a string that is either "REPLACE" for replacement refinement or "ADD" for additive refinement. It is required for the root tile of a tileset; it is optional for all other tiles. When refine is omitted, it is inherited from the parent tile."

  • i think we should use dynamic sse as the link i sent you in chat.

can you please commit your modif?

@autra
Copy link
Contributor

autra commented Aug 29, 2017

LGTM Thanks!

@Jeremy-Gaillard
Copy link
Contributor

We need to define only one time refine, then it's optional!

My bad, I'll add it to the list of thing to fix.

@autra autra merged commit e8ce7b7 into master Aug 29, 2017
@autra autra deleted the 3dtiles-support branch August 29, 2017 13:39
@nguyenign
Copy link

ok jeremy but do attention, refine is not fixed, we can have many small 3dtiles in a big 3dtiles with which use different refine method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants