-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (3dtiles): fix SSE computation #459
Conversation
Use distance to bounding volume instead of distance to center of the bounding volume Issue: #185
d8418e8
to
f568370
Compare
It seems to me that it continues to download all the tiles! |
Can you give me your tileset.json please? |
you can find the download link in this issue, but if it's not enough i can send you a bigger 3dtiles. |
Your problem isn't really a bug. We tried making your tileset work and we identified two issues:
So it works properly, it's just that the building disappear only when you're very far away. We will make a PR to change the SSE threshold and make it customisable. |
"The refine property is a string that is either "REPLACE" for replacement refinement or "ADD" for additive refinement. It is required for the root tile of a tileset; it is optional for all other tiles. When refine is omitted, it is inherited from the parent tile."
can you please commit your modif? |
LGTM Thanks! |
My bad, I'll add it to the list of thing to fix. |
ok jeremy but do attention, refine is not fixed, we can have many small 3dtiles in a big 3dtiles with which use different refine method. |
Use distance to bounding volume instead of distance to center of the bounding volume
Issue: #185