Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate BrowserAuthorizationCallbackHandler into BrowserAuthorizationClient #103

Closed
Tracked by #102
mattbjordan opened this issue Jan 25, 2023 · 0 comments · Fixed by #123
Closed
Tracked by #102

Consolidate BrowserAuthorizationCallbackHandler into BrowserAuthorizationClient #103

mattbjordan opened this issue Jan 25, 2023 · 0 comments · Fixed by #123
Assignees

Comments

@mattbjordan
Copy link
Contributor

Get rid of BrowserAuthorizationCallbackHandler and have everything be handled by BrowserAuthorizationClient.

The BrowserAuthorizationCallbackHandler and BrowserAuthorizationClient now share many of the same options (or will once #88 is merged), so their functionality makes more sense to be combined now.

Notes from @evelynpreslar-bentley in #88 (comment)

The main incentive I had for splitting these into 2 classes was to make the config as simple as possible. Before oidc-client-ts made the client-id and authority required for handling callbacks, this made more sense, because all you needed was a redirect-uri. Unless we make the effort to preserve that simplicity, though, I agree that merging the two classes into one starts to make more sense.

Keeping them separate does make it easier for apps to handle callbacks as early as possible, since less configuration is required. Previously, I saw many SPA apps using the same client used for signin also being used to handle callbacks. This meant that half the app would load before handling redirects, because certain config variables were needed, but I don’t think that’s a good enough reason on its own to advocate keeping them separate. Apps should have a special route for redirects anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants