open doesn't work on some user machines, why not use electron.shell.openPath?

[MichaelBelousov]

Can we switch from using open here
to electron.shell.openPath, as recommended in the README of open itself?

I have found users where open doesn't work to open the browser (as it's used here anyway), where as electron's shell.openPath works fine.

[ben-polinsky]

Reopening as openPath is incorrect - that is for paths not urls and fails on mac os. openExternal is the way to go. I imagine Windows is able to forward the url from explorer to default browser.

[MichaelBelousov]

The current latest version of the desktop auth client doesn't work on linux and mac. Can reproduce on a desktop application I'm working on which is using the latest (@itwin/electron-authorization@0.13.0)

I can confirm that openExternal works on linux, but I haven't tried windows, going to soon.

[ben-polinsky]

Sorry @MichaelBelousov it's gotten caught up in a PR with some other things. I'll extract that since it is an easy fix and we can release it asap.

[MichaelBelousov]

I wouldn't describe it as urgent on my end @ben-polinsky, just been a bit and wanted to make sure it's still being worked on. Can wait for the larger PR too.

[ben-polinsky]

Definitely a priority.

[MichaelBelousov]

A colleague confirmed using openExternal works on windows.

[ben-polinsky]

merged.. waiting for release

[ben-polinsky]

This is released in @itwin/electron-authorization@0.14.0
https://github.com/iTwin/auth-clients/releases/tag/%40itwin%2Felectron-authorization_v0.14.0