Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

React 18 support #633

Closed
4 tasks
mayank99 opened this issue Apr 21, 2022 · 3 comments · Fixed by #656
Closed
4 tasks

React 18 support #633

mayank99 opened this issue Apr 21, 2022 · 3 comments · Fixed by #656
Assignees
Labels
enhancement New feature or request

Comments

@mayank99
Copy link
Contributor

CRA and create-vite ship with react 18, which our package.json is not compatible with, so npm install fails.
image

Action items

  • Update peer deps react version in package.json ‼️
  • Update react version in dev deps (will need to use sb 6.5 and testing lib 13)
  • Update any components that are using old APIs (e.g. ReactDOM.render in Toaster.tsx)
  • Check components in new StrictMode (e.g. in vite test app)
@mayank99 mayank99 added the enhancement New feature or request label Apr 21, 2022
@bentleyvk
Copy link
Contributor

Update any components that are using old APIs (e.g. ReactDOM.render in Toaster.tsx)

Won't this break old React versions?

@mayank99
Copy link
Contributor Author

Update any components that are using old APIs (e.g. ReactDOM.render in Toaster.tsx)

Won't this break old React versions?

I think we could keep backwards compatibility somehow. In this case, a simple fix could be to use createPortal.

@bentleyvk
Copy link
Contributor

I think we also should test on both React versions. But not sure whether just unit tests or visual tests too.

@veekeys veekeys self-assigned this Apr 25, 2022
@mayank99 mayank99 linked a pull request May 27, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants