Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a legend for SBML #696

Closed
ugurdogrusoz opened this issue Mar 31, 2023 · 8 comments
Closed

Prepare a legend for SBML #696

ugurdogrusoz opened this issue Mar 31, 2023 · 8 comments
Assignees
Labels
task Task to be done
Milestone

Comments

@ugurdogrusoz
Copy link
Contributor

@SelbiEreshova Can you tell me where to find this information? Which node can connect to which type of node via what kind of edge?

@ugurdogrusoz ugurdogrusoz added the task Task to be done label Mar 31, 2023
@ugurdogrusoz ugurdogrusoz added this to the version 4.0 milestone Mar 31, 2023
@ugurdogrusoz ugurdogrusoz self-assigned this Mar 31, 2023
@SelbiEreshova
Copy link
Collaborator

@ugurdogrusoz The legend for SBML is similar to CellDesigner's: https://www.celldesigner.org/help/images/components42.png
Also, you can see the exact rules in the GSoC report: https://docs.google.com/document/d/17Yp1YPOVLc3PJYNRKO9FeCiH_bzyK8rVv08jGs3ilyQ/edit?usp=sharing

@ugurdogrusoz ugurdogrusoz assigned umut-er and unassigned ugurdogrusoz Jun 6, 2024
@ugurdogrusoz
Copy link
Contributor Author

@umut-er Other Legends (see under Legend menu) have been prepared using Inkscape and used in .svg format. Please use the same format/style and create one for SBML (now that Newt 4 supports an SBML palette).

umut-er added a commit to umut-er/newt that referenced this issue Jun 10, 2024
@umut-er umut-er mentioned this issue Jun 10, 2024
@ugurdogrusoz
Copy link
Contributor Author

Looks good thanks. One minor improvement: can we increase the width of the window so that the title fits in a single line?

umut-er added a commit that referenced this issue Jun 10, 2024
@umut-er
Copy link

umut-er commented Jun 10, 2024

This worked on my local computer. Next deployment is at 19.30. If it doesn't work on the server I can change it again.

@SelbiEresh
Copy link

SelbiEresh commented Jun 12, 2024

@umut-er
There seems to some minor mistakes in the notation:

  1. Translation consumption and translation production. Notice that the line contain . instead of .. Otherwise there is no difference between translation and transcription.
  2. The edge 'negative influence'
  3. The edge 'unknown reduced stimulation '

Please refer to cell designer's legend for correct notation : https://www.celldesigner.org/help/images/components42.png

@ugurdogrusoz ugurdogrusoz reopened this Jun 12, 2024
umut-er added a commit that referenced this issue Jun 13, 2024
@umut-er
Copy link

umut-er commented Jun 13, 2024

Hey, thanks for the review! It should be fixed now. We can close this issue.

@ugurdogrusoz
Copy link
Contributor Author

Please confirm @SelbiEreshova here

@SelbiEresh
Copy link

Yes, it looks correct now. Thank you @umut-er!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task to be done
Projects
None yet
Development

No branches or pull requests

4 participants