Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo CE: Broken reflections #348

Closed
Aerocatia opened this issue Apr 12, 2019 · 7 comments
Closed

Halo CE: Broken reflections #348

Aerocatia opened this issue Apr 12, 2019 · 7 comments

Comments

@Aerocatia
Copy link

Halo has an issue rendering reflections in gallium nine, I've made a video trying to show it Here.
apitrace will still not work for me in this game, so I can't provide one of those unfortunately.

Interesting to note is the orange and yellow pattern in the above video is part of the lightmap that is not normally drawn.

@axeldavy
Copy link

Is this with this repo or a release of mesa ?

@Aerocatia
Copy link
Author

Both mesa 19.0.1 release, and 19.0.1 with cb54ef9 and 13c3640 applied.

@axeldavy
Copy link

It's possible some patches on our master fixes the issue. Maybe
8c351cc
9c66041

I can test if you tell me how to reproduce fast (multiplayer map ?)

@Aerocatia
Copy link
Author

It's the very start of the level "Two Betrayals" (map_name c40 in the game console)

@Aerocatia
Copy link
Author

With both those commits applied it still happens, and even seems worse.

@axeldavy
Copy link

how does it work ? I start the game with -console -devmode, but it doesn't start with a console.
I found a key on the keyboard that opens a command starting with halo( but if I put map_name c40) it doesn't do anything, even with lan started.

@axeldavy
Copy link

I figured out how to get the map

axeldavy added a commit that referenced this issue Apr 27, 2019
Systemmem has a specific behaviour we don't
mimick exactly.
That makes Halo feel free to use nooverwrite
with it all the time, even when reading again
at the same location.
Ignore nooverwrite to have proper synchronization.

Fixes: #348

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
axeldavy added a commit that referenced this issue Apr 27, 2019
Systemmem has a specific behaviour we don't
mimick exactly.
That makes Halo feel free to use nooverwrite
with it all the time, even when reading again
at the same location.
Ignore nooverwrite to have proper synchronization.

Fixes: #348

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants