-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Output Formatting #109
Comments
Initial implementation with the Markdown plugin can be found here: https://github.com/iainbrighton/PScribo/tree/Issue36. Here is the contents of the
|
Was there a plan to finish this at some point? Or were you looking for assistance to test it? |
The way I handled this in the JSON plugin is I included the header only once at the beginning and the footer only once at the end. My thought was the header/footer could potentially contain valuable information but it doesn't need to be seen more than once given there's no actual "pages".
I'd say keep it simple for MVP. The tried and true traditional image links referencing the external file(s) will be fine for most folks. Additionally, I've performed an initial review of the Markdown plugin code. Overall, it's looking pretty good! Outside of the items referenced above, here's some bugs/oddities I found:
|
Markdown is meant to be a human-readable document format and some PScribo options aren't well suited to its output (unless converted to Html by a parser/renderer). Whilst working on the Markdown plugin, several rendering questions have arisen and I'd like the community's feedback.
Should headers and footers be included in Markdown (
.md
) documents?.md
file is rendered in Html, there is no pseudo pagination like the PScribo Html pluginShould image data be included at the bottom of the Markdown (
.md
) document?.md
file can be converted to Html without any external dependencies but makes the .md file very messy/cluttered.md
file is rendered/converted into HtmlAny feedback is greatly appreciated!
Thanks, Iain
The text was updated successfully, but these errors were encountered: