Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install target does not copy DLLs on windows #47

Closed
jcar87 opened this issue Sep 27, 2017 · 2 comments
Closed

Install target does not copy DLLs on windows #47

jcar87 opened this issue Sep 27, 2017 · 2 comments

Comments

@jcar87
Copy link

jcar87 commented Sep 27, 2017

When building as shared libraries on windows (the default), the "install" target doesnt copy the DLLs (typically to a "bin" directory).

This is because in the install command (CMakeLits.txt) there is no instructions to copy "runtime" files.

It should look something like this:

install(TARGETS ${LIBRARY_NAME} EXPORT ${LIBRARY_NAME}Config
        LIBRARY DESTINATION lib
        RUNTIME DESTINATION bin
        ARCHIVE DESTINATION lib)

@iamantony
Copy link
Owner

Hello @jcar87!

Sorry for a late reply. Thank you for the issue! Fixed in commit 5ba4b2c.

Unfortunately, make install command will not work with qmake build on Windows. Does anyone know how to fix it?

@siakc
Copy link

siakc commented Jan 12, 2018

This is not true. I have recently installed "requests" with that command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants