Data model of my Blog App #2
Conversation
There was a problem hiding this comment.
Hi 👋 @iambenkis,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔️ The PR title and description look good and professional.
✔️ Proper Gitflow.
✔️ Descriptive commit messages.
✔️ No linter errors.
Required Changes ♻️
Check the comments under the review.
- The readme file should be filled with all the necessary instructions, kindly fill out all the getting started and how to run the project.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag @elisha2kyakpo1 in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
| class CreateComments < ActiveRecord::Migration[7.0] | ||
| def change | ||
| create_table :comments do |t| | ||
| t.string :text | ||
|
|
||
| t.timestamps | ||
| end | ||
| end |
There was a problem hiding this comment.
- It looks like there is an error in the comments migration file. Take a look at the image below.
There was a problem hiding this comment.
- Thanks for your review, however, @elisha2kyakpo1 can you be more clear on that because , for me, I did not get an error. What did you do to get the error?
There was a problem hiding this comment.
@elisha2kyakpo1 Take a look at this picture
There was a problem hiding this comment.
STATUS: CHANGES REQUIRED ♻️
Hi @iambenkis👋,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
To Highlight 🎉
- No linter errors. ✔️
- Gitflow is followed. ✔️
- Professional README file. ✔️
- PR has a good title and summary. ✔️
Required Changes ♻️
- As requested by the previous reviewer, Please update the README file and add steps on how to install and run the project. (Currently, there're no instructions available only headings present)
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Hi @thecodechaser, thank you for your feedback. Can you kindly tell me the problem in the picture sent by the previous review? Take a look at this picture
|
There was a problem hiding this comment.
Status: Approved ✔️
Hi Benjamin,
Your project is complete! There is nothing else to say other than... it's time to merge it 🍾 Congratulations! 🎉💯🌟
Highlights 👍
- Data model properly implemented
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
You can also consider:
- Kindly describe between 1-3 key features of the application.
- I think you should change the header title Authors to Author in your ReadMe, as this project is worked on by a sole contributor. You can optionally also change it to Author(s) to cater for future contributors.
- MIT license link in your ReadMe is broken, kindly endeavor to fix it, and remove guide note below it.
Implementing the above change(s) will make your ReadMe/ repository stand out even better 😉
Cheers..Happy coding!💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Blog App 🏴
In this milestone I create a data model of my blog App using rails
Checklists 🥇
Results