Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 : setup Leadbord project #1

Merged
merged 19 commits into from
Aug 23, 2022
Merged

Conversation

iambenkis
Copy link
Owner

A leaderboard is showing the names and current scores of the leading competitors. The project is set up as a JavaScript project using webpack and ES6 features.

Checklist

  • webpack to bundle JavaScript.
  • ES6 modules to write modular JavaScript.
  • Use of Gitflow

Copy link

@DammyShittu DammyShittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iambenkis,

APPROVED 🟢

Highlights

✔️ Descriptive PR
✔️ Passing linters
✔️ Good branch name

Great implementation of all the requirements in this milestone. 👏

You have done an amazing job 👍

Your project is complete! There is nothing else to say other than... it's time to merge it. :shipit:

Congratulations! 🎉

CHEERS AND HAPPY CODING!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@iambenkis iambenkis merged commit dad73e0 into develop Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants