-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project accessibility #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required Changes ♻️
Hey Team (@iambenkis, @Suzi216) 👋
Highlights 🥇
✔️ Following Linters
✔️ Following GitHub Flow
✔️ Basic Structure is good
✔️ Can be maximized upto 200%
Good job on implementing some of the requirements but there are some issues that you still need to work on to go to the next project but you are almost there! 😊
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @HAMMAS-SALEEM in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iambenkis and @Suzi216 ,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
Linters are passing 👍
The project is running successfully 👍
PR is well descriptive 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Checklist
LINKS:
-
Portfolio/index.html
Line 12 in 1319a80
-
Portfolio/index.html
Lines 35 to 38 in 1319a80
-
Portfolio/index.html
Lines 48 to 53 in 1319a80
-
Portfolio/index.html
Lines 89 to 91 in 1319a80
-
Portfolio/index.html
Lines 232 to 234 in 1319a80
-
Portfolio/index.html
Line 351 in 1319a80
-
Portfolio/index.html
Lines 340 to 341 in 1319a80
-
Portfolio/index.html
Lines 330 to 331 in 1319a80
-
Portfolio/style.css
Lines 362 to 364 in 1319a80