Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project accessibility #12

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Project accessibility #12

merged 6 commits into from
Jul 12, 2022

Conversation

iambenkis
Copy link
Owner

@iambenkis iambenkis commented Jul 12, 2022

Checklist

  • Page title: No issue found
  • Image alternative : Issue corrected
  • Text headings : No issue
  • Color contrast : No issue
  • Resize : No issue
  • Interaction : No issue
  • Moving content : No issue
  • Multimedia : No issue
  • Basic structure of the page : No issue found

LINKS:
-

<title>Benjamin's Portfolio</title>

-

Portfolio/index.html

Lines 35 to 38 in 1319a80

<h1>
I'm Benjamin <br>
Glad to see <br class="br"> you!
</h1>

-

Portfolio/index.html

Lines 48 to 53 in 1319a80

<ul class="icons">
<li class="icon"><img src="./images/twitter.png" alt="twitter logo "></li>
<li class="icon"><img src="./images/Linkedin-icon.png" alt="linkedin logo"></li>
<li class="icon"><img src="./images/github.png" alt="github logo"></li>
<li class="icon"><img src="./images/angellist.png" alt="Angelist logo"></li>
<li class="icon"><img src="./images/medium.png" alt="Medium logo"></li>

-

Portfolio/index.html

Lines 89 to 91 in 1319a80

<img src="./images/Counter.png" alt="counter">
<p>Full stack dev</p>
<img src="./images/Counter.png" alt="counter">

-

Portfolio/index.html

Lines 232 to 234 in 1319a80

<img src="./images/Counter.png" alt="counter">
<p>Back end dev</p>
<img src="./images/Counter.png" alt="counter">

-
<button type="submit">Get in Touch</button>

-

Portfolio/index.html

Lines 340 to 341 in 1319a80

<label><input class="input-field" type="text" name="name" maxlength="30" placeholder="Type your name" required></label>
<label><input class="input-field" type="email" name="email" placeholder="Username@domain.ext" required></label>

-

Portfolio/index.html

Lines 330 to 331 in 1319a80

<h2 class="contact-me-text">Contact me</h2>
<p class="contact-me-brief">

-

Portfolio/style.css

Lines 362 to 364 in 1319a80

.input-field-box button:hover {
color: #fff;
background-color: blue;

Copy link

@HAMMAS-SALEEM HAMMAS-SALEEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required Changes ♻️

almost-there

Hey Team (@iambenkis, @Suzi216) 👋

Highlights 🥇

✔️ Following Linters
✔️ Following GitHub Flow
✔️ Basic Structure is good
✔️ Can be maximized upto 200%

Good job on implementing some of the requirements but there are some issues that you still need to work on to go to the next project but you are almost there! 😊

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @HAMMAS-SALEEM in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
Copy link

@ishimwezachee ishimwezachee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iambenkis and @Suzi216 ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Linters are passing 👍
The project is running successfully 👍
PR is well descriptive 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@iambenkis iambenkis merged commit 38d8e50 into master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants