Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using only country in nomenclature config breaks CodeList #319

Closed
phackstock opened this issue Feb 8, 2024 · 2 comments · Fixed by #320
Closed

Using only country in nomenclature config breaks CodeList #319

phackstock opened this issue Feb 8, 2024 · 2 comments · Fixed by #320
Assignees
Labels
bug Something isn't working

Comments

@phackstock
Copy link
Contributor

I saw this in https://github.com/iiasa/openmod4africa-workflow, where the latest nomenclature update in combination with a nomenclature config where in the region dimension there's only the country attribute:

repositories:
  openENTRANCE:
    url: https://github.com/openENTRANCE/openentrance
definitions:
  variable:
    repository: openENTRANCE
  region:
    country: true

It broke in the test here: https://github.com/iiasa/openmod4africa-workflow/actions/runs/7829213013/job/21360733654.

Issue is that

for repo in config.definitions.region.repositories:

attempts to iterate over the region.repositories attribute which is empty.

@phackstock phackstock added the bug Something isn't working label Feb 8, 2024
@phackstock phackstock self-assigned this Feb 8, 2024
@danielhuppmann
Copy link
Member

Same just happened at openENTRANCE/openentrance#326, which doesn’t even have a nomenclature.config file…?

@phackstock
Copy link
Contributor Author

Just commented on openENTRANCE/openentrance#326. The issue is a different one, came with the same PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants