Addressing post-merge comments on #263 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
1327
to
1328
| finally | ||
| close(result) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| finally | |
| close(result) |
| # Utility function for handling "infinity" strings for datetime types to reduce duplication | ||
| function _tryparse_datetime_inf( | ||
| typ::Type{T}, str, f=typ | ||
| )::Union{T, Nothing} where T <: Dates.AbstractDateTime |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| )::Union{T, Nothing} where T <: Dates.AbstractDateTime | |
| )::Union{T,Nothing} where {T<:Dates.AbstractDateTime} |
|
codecov has gone down because we deleted about 30 LOC. |
iamed2
reviewed
Feb 23, 2023
| timestamptz_formats(::Type{ZonedDateTime}) = TIMESTAMPTZ_ZDT_FORMATS | ||
| timestamptz_formats(::Type{UTCDateTime}) = TIMESTAMPTZ_UTC_FORMATS | ||
| function pqparse(::Type{ZonedDateTime}, str::AbstractString) | ||
| parsed = _tryparse_datetime_inf(ZonedDateTime, str, Base.Fix2(ZonedDateTime, tz"UTC")) |
There was a problem hiding this comment.
This adds an additional function abstraction in a couple places so I checked performance between this and master; looks good 👍
|
Is a patch release fine? We aren't really changing any existing functionality. |
Yup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse(DateTime, x)methods Added support for parsing timestamptz as UTCDateTime #263 (comment)TIMESTAMP_FORMATfor UTCDateTime Added support for parsing timestamptz as UTCDateTime #263 (comment)"+00"rather than regex handling-00,+00:00, etc. Added support for parsing timestamptz as UTCDateTime #263 (comment)