Updates for Julia 1.0 #41
Conversation
src/LibPQ.jl
Outdated
| @@ -7,15 +7,15 @@ using Compat.Dates | |||
| using DocStringExtensions | |||
| using Decimals | |||
| using DataStreams | |||
| using Base.Iterators: zip, product | |||
| using IterTools: imap | |||
| import Base.Iterators: zip, product | |||
There was a problem hiding this comment.
Why change this? Since these functions aren't being overloaded, using is appropriate.
There was a problem hiding this comment.
thanks. just understood that how to import and using. good time in the hackathon!
There was a problem hiding this comment.
I wonder that which one makes this warning on the ci.
┌ Warning: `using A: B` will only be allowed for single bindings, not modules. Use `using A.B` instead
│ caller = ip:0x0
└ @ Core :-1
https://ci.appveyor.com/project/invenia/libpq-jl/build/job/4d449u0l8khpd2il#L148
There was a problem hiding this comment.
oh, there's also Julia issue #25397 . I don't know much.
src/LibPQ.jl
Outdated
| @@ -7,15 +7,15 @@ using Compat.Dates | |||
| using DocStringExtensions | |||
| using Decimals | |||
| using DataStreams | |||
| using Base.Iterators: zip, product | |||
| using IterTools: imap | |||
| import Base.Iterators: zip, product | |||
There was a problem hiding this comment.
Please use using and not import for all of these, including Memento (although the explicit imports are fine)
src/parsing.jl
Outdated
| return (sv, start(sv)) | ||
| end | ||
| if VERSION >= v"0.7.0-DEV.5125" | ||
| Base.iterate(pqv::PQValue, i=1) = iterate(string_view(pqv), i) |
There was a problem hiding this comment.
There is no guarantee that the first state of string iteration is 1, so iterate(pqv::PQValue) should pull it from iterate(string_view(pqv)). Same is true of the other iteration methods.
|
yahhh, I'm going to fix the |
src/parsing.jl
Outdated
| end | ||
| if VERSION >= v"0.7.0-DEV.5125" | ||
| Base.iterate(pqv::PQValue) = iterate(string_view(pqv)) | ||
| Base.iterate(pqv::PQValue, i) = iterate(string_view(pqv), i) |
There was a problem hiding this comment.
This creates string_view each time; it should be passed around as part of the state as in the old iteration functions below. That should only hold for PQValue, not the other iterators though.
src/parsing.jl
Outdated
| iterate(pqv, (sv, firstindex(sv))) | ||
| end | ||
| function Base.iterate(pqv::PQValue, (sv, sv_state)) | ||
| iterate(sv, sv_state) |
There was a problem hiding this comment.
This generates just the item and the state for sv, but it has to put sv back in the state that it returns
src/parsing.jl
Outdated
| @@ -118,7 +118,10 @@ if VERSION >= v"0.7.0-DEV.5125" | |||
| iterate(pqv, (sv, firstindex(sv))) | |||
There was a problem hiding this comment.
Sorry, missed this last time, but you need to actually iterate sv in this function; firstindex is not guaranteed to be the iteration state.
|
|
- iterate PQValue, PQTypeMap, PQConversions - add 1.0 to the CIs
|
Note that your scripts are failing on 1.0 because of package management deprecations. You can see an example of some updated |
|
@wookay are you interested in fixing those or shall I? |
|
@ExpandingMan , @iamed2 thanks. please fix anytime that you want. and It failed on LayerDicts.jl in Julia 1.0. |
|
LayerDicts seems fixed, any chance we can merge that and re-run this? It would be a shame to have to use forks of LibPQ, it seems in pretty good shape. |
|
That's my to-do to-day |
|
It's been taking a while to get tagged versions of dependencies but I think we're nearly there. |
hi. fixed at darwin room.