Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordinal formatting in Swedish #743

Closed
Kakebake opened this issue Dec 3, 2019 · 1 comment · Fixed by #745 or BlueWallet/BlueWallet#862 · May be fixed by cds-snc/apply-for-a-grant#32
Closed

Ordinal formatting in Swedish #743

Kakebake opened this issue Dec 3, 2019 · 1 comment · Fixed by #745 or BlueWallet/BlueWallet#862 · May be fixed by cds-snc/apply-for-a-grant#32
Labels
released

Comments

@Kakebake
Copy link

Kakebake commented Dec 3, 2019

Describe the bug
When using the format for ordinal numbers (Do) in Swedish the formatting is wrong for 1 and 2. It becomes am instead of a. This is likely because the date is formatted a second time, and a is formatted to be am.

What happens:
> dayjs('2019-01-01').locale('sv').format('dddd Do MMMM')
'tisdag 1am januari'

> dayjs('2019-01-02').locale('sv').format('dddd Do MMMM')
'onsdag 2am januari'

> dayjs('2019-01-03').locale('sv').format('dddd Do MMMM')
'torsdag 3e januari'

Expected behavior
I expect 1st to be 1a and 2nd to be 2a
> dayjs('2019-01-01').locale('sv').format('dddd Do MMMM')
'tisdag 1a januari'

> dayjs('2019-01-02').locale('sv').format('dddd Do MMMM')
'onsdag 2a januari'

> dayjs('2019-01-03').locale('sv').format('dddd Do MMMM')
'torsdag 3e januari'

Information

  • Day.js Version 1.8.17
  • OS: MacOS Mojave 10.14.5
  • Browser: Chrome 78
  • Time zone: GMT+1
iamkun added a commit that referenced this issue Dec 8, 2019
@iamkun
fix: Update Swedish locale (sv) fix ordinal error
16c1f38 
fix #743
@iamkun iamkun mentioned this issue Dec 8, 2019
Merged
iamkun added a commit that referenced this issue Dec 8, 2019
@iamkun
fix: Update Swedish locale (sv) fix ordinal error (#745)
49670d5 
fix #743
iamkun pushed a commit that referenced this issue Dec 18, 2019
@semantic-release-bot
chore(release): 1.8.18 [skip ci]
6b587da 
## [1.8.18](v1.8.17...v1.8.18) (2019-12-18)

### Bug Fixes

* Add missing locale type definition ([#716](#716)) ([cde5d0b](cde5d0b))
* Fix .locale() handel unsupported locale ([78ec173](78ec173))
* Update Italian locale (it) ([#727](#727)) ([5b53e98](5b53e98))
* Update locale (fa) ([#733](#733)) ([9ad2e47](9ad2e47))
* Update locale (zh-cn) ([#706](#706)) ([e31e544](e31e544))
* Update locale (zh-cn) meridiem ([#735](#735)) ([15d1b81](15d1b81))
* Update LocaleData plugin to support dayjs().longDateFormat() ([#734](#734)) ([aa0f210](aa0f210)), closes [#680](#680)
* Update Mongolian (mn) locale relativeTime ([#753](#753)) ([6d51435](6d51435))
* Update Swedish locale (sv) fix ordinal error ([#745](#745)) ([49670d5](49670d5)), closes [#743](#743)
@iamkun
Copy link
Owner

iamkun commented Dec 18, 2019

🎉 This issue has been resolved in version 1.8.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this issue Mar 5, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 9, 2020
Open
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.18 [skip ci]
2ed0f45 
## [1.8.18](iamkun/dayjs@v1.8.17...v1.8.18) (2019-12-18)

### Bug Fixes

* Add missing locale type definition ([#716](iamkun/dayjs#716)) ([cde5d0b](iamkun/dayjs@cde5d0b))
* Fix .locale() handel unsupported locale ([78ec173](iamkun/dayjs@78ec173))
* Update Italian locale (it) ([#727](iamkun/dayjs#727)) ([5b53e98](iamkun/dayjs@5b53e98))
* Update locale (fa) ([#733](iamkun/dayjs#733)) ([9ad2e47](iamkun/dayjs@9ad2e47))
* Update locale (zh-cn) ([#706](iamkun/dayjs#706)) ([e31e544](iamkun/dayjs@e31e544))
* Update locale (zh-cn) meridiem ([#735](iamkun/dayjs#735)) ([15d1b81](iamkun/dayjs@15d1b81))
* Update LocaleData plugin to support dayjs().longDateFormat() ([#734](iamkun/dayjs#734)) ([aa0f210](iamkun/dayjs@aa0f210)), closes [#680](iamkun/dayjs#680)
* Update Mongolian (mn) locale relativeTime ([#753](iamkun/dayjs#753)) ([6d51435](iamkun/dayjs@6d51435))
* Update Swedish locale (sv) fix ordinal error ([#745](iamkun/dayjs#745)) ([49670d5](iamkun/dayjs@49670d5)), closes [#743](iamkun/dayjs#743)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.18 [skip ci]
4a8d5a4 
## [1.8.18](iamkun/dayjs@v1.8.17...v1.8.18) (2019-12-18)

### Bug Fixes

* Add missing locale type definition ([#716](iamkun/dayjs#716)) ([cde5d0b](iamkun/dayjs@cde5d0b))
* Fix .locale() handel unsupported locale ([78ec173](iamkun/dayjs@78ec173))
* Update Italian locale (it) ([#727](iamkun/dayjs#727)) ([5b53e98](iamkun/dayjs@5b53e98))
* Update locale (fa) ([#733](iamkun/dayjs#733)) ([9ad2e47](iamkun/dayjs@9ad2e47))
* Update locale (zh-cn) ([#706](iamkun/dayjs#706)) ([e31e544](iamkun/dayjs@e31e544))
* Update locale (zh-cn) meridiem ([#735](iamkun/dayjs#735)) ([15d1b81](iamkun/dayjs@15d1b81))
* Update LocaleData plugin to support dayjs().longDateFormat() ([#734](iamkun/dayjs#734)) ([aa0f210](iamkun/dayjs@aa0f210)), closes [#680](iamkun/dayjs#680)
* Update Mongolian (mn) locale relativeTime ([#753](iamkun/dayjs#753)) ([6d51435](iamkun/dayjs@6d51435))
* Update Swedish locale (sv) fix ordinal error ([#745](iamkun/dayjs#745)) ([49670d5](iamkun/dayjs@49670d5)), closes [#743](iamkun/dayjs#743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@Kakebake @iamkun