Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Monthshort, Dayshort to support locale Indonesian #574

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Add: Monthshort, Dayshort to support locale Indonesian #574

merged 2 commits into from
Apr 17, 2019

Conversation

ridhoassuryadi
Copy link
Contributor

@ridhoassuryadi ridhoassuryadi commented Apr 17, 2019 •
edited
Loading

Add Monthshort, Dayshort to support locale Indonesian.

@ridhoassuryadi ridhoassuryadi changed the title Add Monthshort, Dayshort to support locale Indonesian Add: Monthshort, Dayshort to support locale Indonesian Apr 17, 2019
@codecov-io
Copy link

codecov-io commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #574 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #574   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines       966    966           
  Branches    131    131           
===================================
  Hits        966    966
Impacted Files Coverage Δ
src/locale/id.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8fd97...20d78d8. Read the comment docs.

iamkun
iamkun reviewed Apr 17, 2019
View reviewed changes
src/locale/id.js
@@ -4,6 +4,9 @@ const locale = {
name: 'id',
weekdays: 'Minggu_Senin_Selasa_Rabu_Kamis_Jumat_Sabtu'.split('_'),
months: 'Januari_Februari_Maret_April_Mei_Juni_Juli_Agustus_September_Oktober_November_Desember'.split('_'),
weekdaysShort: 'Min_Sen_Sel_Rab_Kam_Jum_Sab'.split('_'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhammadridho Agu -> Agt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just updated

iamkun
iamkun reviewed Apr 17, 2019
View reviewed changes
src/locale/id.js Outdated Show resolved Hide resolved
@iamkun
Copy link
Owner

iamkun commented Apr 17, 2019

Thanks.

@ridhoassuryadi
Copy link
Contributor Author

you're welcome

@iamkun iamkun merged commit 0aa7143 into iamkun:dev Apr 17, 2019
iamkun pushed a commit that referenced this pull request Apr 26, 2019
@semantic-release-bot
chore(release): 1.8.13 [skip ci]
68a04e1 
## [1.8.13](v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](#560)) ([96b917e](96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](#569)) ([9007cc5](9007cc5)), closes [#559](#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](#580)) ([576e93e](576e93e)), closes [#578](#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](800f6c9))
* Fix `.diff` type definition error ([#565](#565)) ([c4921ae](c4921ae)), closes [#561](#561)
* Fix CustomParseFormat plugin bug ([#568](#568)) ([1f5a9db](1f5a9db)), closes [#555](#555)
* Fix relativeTime plugin Math.round bug ([40bea40](40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](#556)) ([9279718](9279718)), closes [#554](#554)
* Update Indonesian locale([#574](#574)) ([0aa7143](0aa7143))
* Update locale month to support both array and function ([#581](#581)) ([b6599d3](b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](#557)) ([d409304](d409304))
@iamkun
Copy link
Owner

iamkun commented Apr 26, 2019

🎉 This PR is included in version 1.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.13 [skip ci]
b38f060 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.13 [skip ci]
ec17709 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
manre57 added a commit to manre57/dayjs that referenced this pull request Sep 12, 2024
@manre57 @semantic-release-bot
chore(release): 1.8.13 [skip ci]
a7e1712 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([aaf5a76](iamkun/dayjs@aaf5a76))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([95c7666](iamkun/dayjs@95c7666)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([d2056fa](iamkun/dayjs@d2056fa)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([20be555](iamkun/dayjs@20be555))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([10f35df](iamkun/dayjs@10f35df)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([3161ebe](iamkun/dayjs@3161ebe)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([cd89839](iamkun/dayjs@cd89839))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([1f89ee7](iamkun/dayjs@1f89ee7)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([77540a2](iamkun/dayjs@77540a2))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([4f1f4d0](iamkun/dayjs@4f1f4d0))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([656a993](iamkun/dayjs@656a993))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamkun iamkun iamkun left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ridhoassuryadi @codecov-io @iamkun