feat: make lowercase localized formats fallback to slightly modified … #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uppercase formats
Codecov Report
@@ Coverage Diff @@
## dev #557 +/- ##
===================================
Coverage 100% 100%
===================================
Files 154 154
Lines 971 971
Branches 136 138 +2
===================================
Hits 971 971
Continue to review full report at Codecov.
|
|
oops, I renamed |
|
No worries. Let me take a look later today and I'll resolve the conflict. |
|
check the current code, just rename to localizedFormat.test.js will be fine |
…FormatsFallback # Conflicts: # test/plugin/localizedFormat.test.js
mariomc
force-pushed
the
lowercaseLocalisedFormatsFallback
branch
from
ee867f4
to
247bede
Compare
iamkun
pushed a commit
that referenced
this pull request
Apr 26, 2019
## [1.8.13](v1.8.12...v1.8.13) (2019-04-26) ### Bug Fixes * Add missing relativeTime and formats for some locales ([#560](#560)) ([96b917e](96b917e)) * Add weekday (locale aware day of the week) plugin ([#569](#569)) ([9007cc5](9007cc5)), closes [#559](#559) * Allow customizing "am" / "pm" strings with locale meridiem function ([#580](#580)) ([576e93e](576e93e)), closes [#578](#578) * Fix `.add` day/week decimal rouding bug ([800f6c9](800f6c9)) * Fix `.diff` type definition error ([#565](#565)) ([c4921ae](c4921ae)), closes [#561](#561) * Fix CustomParseFormat plugin bug ([#568](#568)) ([1f5a9db](1f5a9db)), closes [#555](#555) * Fix relativeTime plugin Math.round bug ([40bea40](40bea40)) * skip square brackets in buddhistEra, advancedFormat plugins ([#556](#556)) ([9279718](9279718)), closes [#554](#554) * Update Indonesian locale([#574](#574)) ([0aa7143](0aa7143)) * Update locale month to support both array and function ([#581](#581)) ([b6599d3](b6599d3)) * Update LocalizedFormat plugin lowercase formats logic ([#557](#557)) ([d409304](d409304))
|
🎉 This PR is included in version 1.8.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26) ### Bug Fixes * Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e)) * Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559) * Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578) * Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9)) * Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561) * Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555) * Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40)) * skip square brackets in buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554) * Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143)) * Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3)) * Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26) ### Bug Fixes * Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e)) * Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559) * Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578) * Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9)) * Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561) * Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555) * Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40)) * skip square brackets in buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554) * Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143)) * Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3)) * Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uppercase formats
This feature, present in moment, is the reason why most locales don't need to define a lowercase locale.