Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gardner): make idempotent #8

Closed
iamnande opened this issue Jan 16, 2022 · 0 comments · Fixed by #9
Closed

feat(gardner): make idempotent #8

iamnande opened this issue Jan 16, 2022 · 0 comments · Fixed by #9
Assignees
@iamnande
Labels
enhancement New feature or request go Change includes changes to Go code proto Changes include new proto generation

Comments

@iamnande
Copy link
Owner

iamnande commented Jan 16, 2022 •
edited
Loading

either need a filter query parameter or a generalized search endpoint (leaning toward the former).

could add a method like (searching by name; duplicated for magics as well):

SearchCards(ctx context.Context, query string) ([]card.Card, error)

that would go here. it would only be used by the seeder program. the implementation would go here.
@iamnande iamnande added enhancement New feature or request go Change includes changes to Go code proto Changes include new proto generation labels Jan 16, 2022
@iamnande iamnande self-assigned this Jan 16, 2022
@iamnande iamnande mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamnande iamnande

Labels
enhancement New feature or request go Change includes changes to Go code proto Changes include new proto generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gardner): make gardner idempotent iamnande/cardmod
1 participant
@iamnande