Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus metric naming best practices not followed #372

Closed
1 of 2 tasks
perkons opened this issue Sep 15, 2023 · 1 comment · Fixed by #377
Closed
1 of 2 tasks

prometheus metric naming best practices not followed #372

perkons opened this issue Sep 15, 2023 · 1 comment · Fixed by #377

Comments

@perkons
Copy link

perkons commented Sep 15, 2023

I'm submitting a ...

  • bug report
  • feature request

What is the current behavior?

The metric name "oracledb_tablespace_free" does not follow the Prometheus naming best practices documented here: https://prometheus.io/docs/practices/naming/

A change would need to be done in the following lines:
https://github.com/iamseth/oracledb_exporter/blob/master/default-metrics.toml#L48
https://github.com/iamseth/oracledb_exporter/blob/master/default-metrics.toml#L55
I am not sure about this line https://github.com/iamseth/oracledb_exporter/blob/master/default-metrics.toml#L17 but it looks like this one too should be "free_bytes"

What is the expected behavior?

Expected metric name would be "oracledb_tablespace_free_bytes"

@Yannig
Copy link
Collaborator

Yannig commented Oct 29, 2023

Hi,

The name is quite old. If we change it, it will broke existing dashboards.

But you can do a PR if you want to change it.

@perkons perkons mentioned this issue Nov 10, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants