-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.2.0 has breaking changes, should not be a minor #94
Comments
I suggest making this backwards-compatible by emitting both events (and adding a deprecation note in the docs). Something like:
And in the case of the new parameter added to |
@msanzv. Sorry and thanks for your help! I would definitely take a look into it this weekend. Along with the backwards-compatible changes, I might add the releases of Github but I'm not sure it would be a good practise. Any recommendation? |
Thank you! |
Yesterday our signup page stopped working because the form wasn't validating, and after an afternoon of investigation, we tracked it down to this library.
The changes in v2.2.0, specifically in commit b5187c2, changed the API quite a lot by both changing the names of the emitted events and also adding a parameter in one of them. I think those kind of changes belong to a major version, or at least to a version that accepts both APIs and marks the old one as deprecated in the docs.
I already tracked it down and made those changes, but this will probably happen to everyone using those events, so writing this here in case case it helps others.
The text was updated successfully, but these errors were encountered: