Prevent assigning someone to review their own GitHub PR

[jeremy-w]

Grabs the PR's info before assigning a reviewer, and grabs the next reviewer if its first draw turned out to be the user that opened the PR in the first place.

[wolfbrain]

👀 @sebastiangeiger

[iamvery]

There was an idea to allow folks to associate their GH username with their slack id. Given such, this would be one of possibly many useful applications. I think I'd prefer that over making an additional HTTP request to GH during assignment... Thoughts on that?

[jeremy-w]

@iamvery: Your scenario assumes that the person asking for the review is also the person who opened the PR. If someone requests a reviewer for someone else's PR, that case will be mishandled unless we ask GitHub who owns the PR. I actually did this today, so it's not 100% made-up. :)

[randomstep]

@iamvery is the extra request much overhead? It seems to my uninformed eyes to be a reasonable "just enough" solution.

FYI @jeremy-w this branch has a conflict currently.

[iamvery]

@jeremy-w that makes sense

@randomstep not if there is a legit case for it (which there seems to be)

I'm trying hard not to be overly pedantic about these things. Fix up the merge conflict and ping me. I'd love to make this better for us :)

[jeremy-w]

@iamvery This has been fixed up to account for next_reviewer taking a room argument.