Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent assigning someone to review their own GitHub PR #36

Merged
merged 6 commits into from
Jan 29, 2016
Merged

Prevent assigning someone to review their own GitHub PR #36

merged 6 commits into from
Jan 29, 2016

Commits on Jan 28, 2016

  1. Skip GitHub PR owner when assigning reviewer 

    This prevents self-assigning reviews.
    @jeremy-w
    jeremy-w committed Jan 28, 2016
    Configuration menu
    Copy the full SHA
    2b49d05 View commit details
    Browse the repository at this point in the history

  2. Float |repo| and |id| to let bindings

    @jeremy-w
    jeremy-w committed Jan 28, 2016
    Configuration menu
    Copy the full SHA
    09c06bc View commit details
    Browse the repository at this point in the history

  3. Allow OctoKit::Client#pull_request throughout 

    This prevents hitting the network for a bogus PR.
    @jeremy-w
    jeremy-w committed Jan 28, 2016
    Configuration menu
    Copy the full SHA
    a12ba4c View commit details
    Browse the repository at this point in the history

  4. Adopt |reply| throughout specs

    @jeremy-w
    jeremy-w committed Jan 28, 2016
    Configuration menu
    Copy the full SHA
    3fd72bf View commit details
    Browse the repository at this point in the history

  5. Tie first command directly to fake PR's owner

    @jeremy-w
    jeremy-w committed Jan 28, 2016
    Configuration menu
    Copy the full SHA
    f6b7cfa View commit details
    Browse the repository at this point in the history

  6. Hoist common username to |expected_reviewer|

    @jeremy-w
    jeremy-w committed Jan 28, 2016
    Configuration menu
    Copy the full SHA
    1dc0b5c View commit details
    Browse the repository at this point in the history