Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6559: Fixed ezmatrix field form inconsistencies in Content Type form #36

Merged
merged 4 commits into from
Dec 6, 2023
Merged

IBX-6559: Fixed ezmatrix field form inconsistencies in Content Type form #36

merged 4 commits into from
Dec 6, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Nov 23, 2023

Question Answer
JIRA issue IBX-6559
Type bug
Target Ibexa DXP version v4.5
BC breaks no

The label showing double "Columns" text is unnecessary so it was removed. Aside from that header columns are set to always visible.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@barw4 barw4 added Bug Something isn't working Ready for review labels Nov 23, 2023
@barw4 barw4 requested a review from a team November 23, 2023 15:10
@barw4 barw4 self-assigned this Nov 23, 2023
@konradoboza konradoboza requested a review from a team November 28, 2023 08:41
@bogusez bogusez self-assigned this Nov 29, 2023
This was referenced Nov 29, 2023
Closed
Closed
@bogusez
Copy link

bogusez commented Nov 29, 2023

@barw4 something is broken here:
Screenshot 2023-11-29 at 11 15 55

https://recordit.co/6rxZ5996ra

@barw4
Copy link
Contributor Author

barw4 commented Dec 1, 2023

@bogusez you were testing https://issues.ibexa.co/browse/IBX-6845 which is exactly the same case. Please, include this PR with #33 and validate if it's okay.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

bogusez
bogusez approved these changes Dec 5, 2023
View reviewed changes
Copy link

@bogusez bogusez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests passed.

@ciastektk ciastektk merged commit c96904f into 4.5 Dec 6, 2023
14 checks passed
@ciastektk ciastektk deleted the ibx-6559-fix-matrix-content-type-form-inconsistencies branch December 6, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@ciastektk ciastektk ciastektk approved these changes

@dew326 dew326 dew326 approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@bogusez bogusez bogusez approved these changes

Assignees

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@barw4 barw4

@bogusez bogusez

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@barw4 @bogusez @Nattfarinn @ciastektk @dew326 @ViniTou @konradoboza