IBX-6845: Matrix field columns table header not present until saved #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
force-pushed
the
IBX-6845-matrix-field-columns-table-header-not-present-until-saved
branch
from
3950d46
to
c3cdb4f
Compare
GrabowskiM
commented
Oct 23, 2023
| tableBody.appendChild(emptyPlaceholder); | ||
| } | ||
|
|
||
| setTimeout(() => { |
There was a problem hiding this comment.
This timeout is necessary as without it hiding/removing elements happens to fast, before returning emptyPlaceholder and for short moment there's no element and whole table "jumps"
Gengar-i
approved these changes
Oct 24, 2023
lucasOsti
approved these changes
Oct 24, 2023
dew326
reviewed
Oct 25, 2023
| checkbox.dispatchEvent(new Event('change')); | ||
| checkbox.closest(SELECTOR_COLUMN).remove(); | ||
| }); | ||
| }, 1); |
There was a problem hiding this comment.
1 is very suspicious, maybe 0 will work as well?
|
Kudos, SonarCloud Quality Gate passed!
|
dew326
approved these changes
Oct 27, 2023
This was referenced Nov 6, 2023
|
Regression tests passed. |
dew326
deleted the
IBX-6845-matrix-field-columns-table-header-not-present-until-saved
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ref: https://issues.ibexa.co/browse/IBX-6845
Req ibexa/admin-ui#953