-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mastarm to v5.0.2 to resolve security vulnerabilities #442
Conversation
It looks like there are a lot of new flow type issues under mastarm 5. |
What level of effort would it take to fix the flow-type errors? I think we ought to revert the flow upgrade in mastarm if it's too much effort. |
@evansiroky, I'm not exactly sure, but basically all of the actions are broken (including some stuff in |
Ah, looks like this was due to a change in 0.85 https://medium.com/flow-type/asking-for-required-annotations-64d4f9c1edf8 |
@evansiroky, I'm not quick enough with absorbing this flow stuff to make it worth our time, so I would say we should bump down to v0.85.0 of flow-bin in mastarm unless you want to take a crack. |
Yeah, let's definitely downgrade flow-bin in mastarm to the latest possible version that still works, but also create an issue to update to the latest flow. |
OK, I've got a branch ready to push once I get the correct permissions set by Trevor on mastarm. |
I just made you an admin on mastarm. |
0.85.0 introduces a host of new flow type issues in Data Tools. This is explained in this blog post: https://medium.com/flow-type/asking-for-required-annotations-64d4f9c1edf8 re ibi-group/datatools-ui#442
Assigning back to @landonreed to update to latest mastarm. |
Codecov Report
@@ Coverage Diff @@
## dev #442 +/- ##
==========================================
+ Coverage 15.09% 15.09% +<.01%
==========================================
Files 325 325
Lines 15830 15833 +3
Branches 4803 4804 +1
==========================================
+ Hits 2389 2390 +1
- Misses 11496 11498 +2
Partials 1945 1945
Continue to review full report at Codecov.
|
@evansiroky, I think you mentioned that you might already have fixes for the flow issues here. Is that correct? |
Yep: a9dec1f |
Assigning back to Landon so the Travis builds can run properly. |
OK, build is complete. Once you add a review, I think we can merge. |
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Checklist
dev
before they can be merged tomaster
)Description
Bump mastarm to 5.0.2 to fix vulnerabilities.