New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MapD] Cast to float #1737
[MapD] Cast to float #1737
Conversation
awesome! thank you so much @cpcloud ! |
@xmnlab Can you rebase? |
rebase done! |
It looks like I didn't fix the auth stuff. I know why, putting up a PR. |
@cpcloud thanks! |
Ah actually there appear to be a few cases where I call |
@cpcloud awesome! thanks I will do it! |
I am trying your changes on #1683 |
Codecov Report
@@ Coverage Diff @@
## master #1737 +/- ##
==========================================
- Coverage 87.34% 85.41% -1.93%
==========================================
Files 80 80
Lines 14934 14934
Branches 1919 1919
==========================================
- Hits 13044 12756 -288
- Misses 1544 1834 +290
+ Partials 346 344 -2
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1737 +/- ##
==========================================
- Coverage 87.34% 85.41% -1.93%
==========================================
Files 80 80
Lines 14934 14934
Branches 1919 1919
==========================================
- Hits 13044 12756 -288
- Misses 1544 1834 +290
+ Partials 346 344 -2
|
@xmnlab LGTM! Merging. |
Resolves #1682