ENH/CLN: Enable window function tests where possible #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
reviewed
May 11, 2019
There was a problem hiding this comment.
it seem awesome @cpcloud
I just added some comment related to the old code that maybe would be good to change (just move up a bit one line)
the current testes that are failing are:
FAILED ibis/tests/all/test_window.py::test_window[PostgreSQL-rank]
FAILED ibis/tests/all/test_window.py::test_window[PostgreSQL-dense_rank]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-lag]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-lead]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-rank]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-dense_rank]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-percent_rank]
FAILED ibis/tests/all/test_window.py::test_window[Impala-lag]
FAILED ibis/tests/all/test_window.py::test_window[Impala-lead]
FAILED ibis/tests/all/test_window.py::test_window[Impala-rank]
FAILED ibis/tests/all/test_window.py::test_window[Impala-dense_rank]
related to the error:
E AssertionError: Attributes are different
E
E Attribute "dtype" are different
E [left]: int64
E [right]: float64
not sure ... but if the result should be integer, so the expected value maybe could be converted to float if it has NA values .. but I need to check the code locally to be sure of this error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.