feat(api): support deferred objects in literal
#9904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
deferred-literal
branch
3 times, most recently
from
e221216
to
aedb65a
Compare
ncclementi
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Is there a place in the docs, where we could add an example of this? I'm trying to think of how would one would use it and why.
We have this https://ibis-project.org/how-to/analytics/chain_expressions but I'm not sure it is the right place
|
Sure, coming right up. |
cpcloud
force-pushed
the
deferred-literal
branch
from
aedb65a
to
3bfc4f6
Compare
ncclementi
approved these changes
Aug 23, 2024
jcrist
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Seems harmless. The reason we didn't support this before is that ibis.literal doesn't take an expression for any input type. The use case of using deferred in the selectors API to get non-expression values never occurred to me. Not a common use case, but easy enough to support.
cpcloud
force-pushed
the
deferred-literal
branch
from
3bfc4f6
to
a7c76d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing deferred inputs to
literal.