docs: fix doctests for postgres backend #9964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
gmcrocetti
force-pushed
the
docs-postgres-do-connect
branch
from
96761c5
to
4cc7b23
Compare
gmcrocetti
force-pushed
the
docs-postgres-do-connect
branch
from
4cc7b23
to
5fe912c
Compare
gmcrocetti
changed the title
cpcloud
approved these changes
Aug 30, 2024
|
Thanks! We don't run doctests in the backend docs, because that would require spinning up a backend. |
|
I suppose we could do that in the backend test suite proper, 🤔 let me see what's possible there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes doctests of the postgres backend. I couldn't help but notice that the
run doctestsstep of CI is not running for this file and others. I can be overlooking something or is that expected ?Issues closed
There's no open issue for this. Let me know case this doesn't make any sense.