Skip to content
This repository has been archived by the owner on Jul 21, 2022. It is now read-only.

Rename some GitHubCity's properties #167

Open
iblancasa opened this issue Dec 9, 2017 · 3 comments
Open

Rename some GitHubCity's properties #167

iblancasa opened this issue Dec 9, 2017 · 3 comments

Comments

@iblancasa
Copy link
Owner

Some properties from GitHubCity need a new name:

  • __names → __usersToProccess
  • __myusers → __cityUsers
  • __dataUsers → __processedUsers
  • __fin → __ended
  • __excluded → __excludedUsers

This will help to make easier to understand the code and document it.

@iblancasa iblancasa added this to the 1.1.0 milestone Dec 9, 2017
@iblancasa iblancasa self-assigned this Dec 9, 2017
@aaronmaynard
Copy link

aaronmaynard commented Dec 28, 2017

🎨 This is simply combing through the files and exchanging variable names in the src/githubcity folder? I would like to tackle this. Also, does this include the non __* ones? Such as:
dataUsers = self.getSortedUsers(sort)
and
if limit: dataUsers = dataUsers[:limit]

[ci skip]

@iblancasa
Copy link
Owner Author

Hi!
Yes, it is only to rename the variables.

I chose a bad name for the variable __dataUsers. Also, I called a variable as dataUsers in the __exportUsers method.

Actually, __dataUsers and dataUsers are different variables (for this reason I want to rename __dataUsers to __processedUsers). They are different because I want to save all the processed users in __processedUsers (without limit). I use dataUsers the limit first users.

This is so nice!

if limit: dataUsers = dataUsers[:limit]

Thank you! 👍

@aaronmaynard
Copy link

@iblancasa completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants