New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up recipe to point to latest bmcweb OP940 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Reed pushed the fix directly into the repo so closing out |
geissonator
pushed a commit
to geissonator/openbmc-1
that referenced
this pull request
Aug 20, 2020
Per Steven Janssen, this is the minimum bump required to satisfy manufacturing test requirements. Jason Albert (13): Add ecmdChipTarget hash support to pyapi Defined __deepcopy__ functions on classes Added python support for vector<vector<databuffer>> Fix python3 problems in config/build Fixed coredump due to accessing empty list Fix the __deepcopy__ implementation Force python 3 and updated logic around use of linux_distribution Big update to ecmdDllSpy.C Merge pull request #386 from thejta/spy-update Fixed in memory spy db performance Merge pull request #387 from thejta/spy-performance-update Added getSpyImages support Merge pull request #390 from thejta/spy-image-support Joachim Fenkes (7): pyapi: Add support for vector<string> arguments pyecmd: Support list-of-string output arguments, some cleanup pyecmd: Extension support pyecmd: Add FAPI2 attribute get/set support, plus stub code for testing pyecmd: Make fapi2 test conditional on fapi2 being built into ecmd pyecmd: Data buffer improvements pyecmd: Check keyword arguments in Target constructor Joel Stanley (3): Fix device paths again server: Fix linking Fix device paths again Kahn Evans (58): Merge pull request ibm-openbmc#263 from thejta/deepcopy Merge pull request ibm-openbmc#266 from mklight/master Merge pull request ibm-openbmc#268 from mklight/spi_commands More complete use of ECMD_REMOVE_SCOM_FUNCTIONS compile flag Signed-off-by: Kahn Evans <kahnevan@us.ibm.com> Merge pull request ibm-openbmc#270 from kahnevan/remove_scom_functions Merge pull request ibm-openbmc#274 from thejta/vector-vector Use chipUnitNum instead of core in targets Signed-off-by: Kahn Evans <kahnevan@us.ibm.com> Merge pull request ibm-openbmc#278 from kahnevan/remove_core_use Resolve doxygen errors/warnings Signed-off-by: Kahn Evans <kahnevan@us.ibm.com> Merge pull request ibm-openbmc#279 from kahnevan/doxygen_fixes Adding spy APIs to pass in multiple images. Adding ecmdQuerySpyRings() API to get all rings associated with spy and its parity checkers Updated query code as well Use const ecmdChipTargets in new APIs Merge pull request ibm-openbmc#281 from kahnevan/spy_maps update to version 14.19 Merge pull request ibm-openbmc#282 from kahnevan/ecmd14_19 Revert to checking all return codes instead of just a single one for non-enum retry. Signed-off-by: Kahn Evans <kahnevan@us.ibm.com> Merge pull request ibm-openbmc#283 from kahnevan/fix_rc_check Syncing up with what's in Cronus Signed-off-by: Kahn Evans <kahnevan@us.ibm.com> Merge pull request ibm-openbmc#287 from kahnevan/sync_with_cronus Merge pull request ibm-openbmc#286 from lkammath/new_flags Use system _AIX compile flag Signed-off-by: Kahn Evans <kahnevan@us.ibm.com> Merge pull request ibm-openbmc#290 from kahnevan/aix_compile_flag Merge pull request ibm-openbmc#296 from mklight/putmempba_cu_fix Merge pull request #309 from janssens2/mvpdupdate Merge pull request #313 from janssens2/targetupdate Adding empty file for ecmd15 compatibility. Allows it to be included from install path in either release. Merge pull request #322 from thejta/python3-script-fixes Add optional -noignoremask flag to checkrings to skip application of ignoremask to read data Merge pull request #323 from kahnevan/checkrings_noignoremask Merge pull request #320 from kahnevan/dummy_file Merge pull request #317 from janssens2/getsramupdate Merge pull request #331 from janssens2/getsramfixtypo Merge pull request #333 from mklight/ecmdGetProcessingUnit Merge pull request #337 from thejta/coredump-fix Merge pull request #335 from janssens2/buffermod Merge pull request #343 from thejta/fix-deepcopy Merge pull request #348 from janssens2/generici2cslavetarget Merge pull request #325 from fenkes-ibm/pyecmd-extensions Merge pull request #307 from mklight/updated_target_rules Merge pull request #342 from mklight/fapi2_py_attr Add ecmdScomDataHidden lists for perl and python Merge pull request #354 from kahnevan/python_hidden_list_fix Sync up fapi2 files with ekb Add ecmd-core/pyecmd/__pycache__/ to .gitignore Merge pull request #362 from kahnevan/gitignore_update Merge pull request #360 from kahnevan/ekb_fapi2_sync Merge pull request #361 from thejta/update-config Merge pull request #372 from lkammath/python3_update Fix data input on gpr/fpr when using chip/chipunit input Merge pull request #374 from kahnevan/gpr_data_fix Fix for finding latch array entries in hash file in full lookup mode Merge pull request #378 from kahnevan/latch_array_hash_fix Merge pull request #382 from fenkes-ibm/pyecmd_databuffer Fixes for latch caching...it wasn't working right before Merge pull request #384 from kahnevan/latch_cache_fixes Update to valid owners/contacts Merge pull request #391 from kahnevan/owner_update Lakshminarayana R. Kammath (2): Adding support for LDFLAGS and SLDFLAGS to pickup value from environment Use python3 env Matt K. Light (33): BrkptInstruction server support update fapi2::ReturnCode get/putspi get/putspi links and htxt fix doxygen param name add start/stop/step support to BrkptInstruction add SERVER_BRKPT_SBE_PUTSCOM_ERROR error code fix serverlock authorization storage fix target for ecmdGetPbaUnit updated fapi2 target rules for z updated fsi device paths updated makefile Merge branch 'master' into BrkptInstruction fix duplicate RC move delay to its own source file enable SPIInstruction update ecmdGetProcessingUnit fix return code check in fapi2 subroutine executor support getting simple value fapi2 attributes from python support 1D fapi2 attributes from python support 2,3,4D fapi2 attributes from python fapi2GetAttr always returns rc and data, enable requesting dimensions with data add python fapi2SetAttr() Merge branch 'fapi2_py_attr' of https://github.com/fenkes-ibm/eCMD into fenkes-ibm-fapi2_py_attr add fapi2/capi dir to VPATH for dllStub Merge branch 'fenkes-ibm-fapi2_py_attr' into fapi2_py_attr remove pau-iohs relationship make fapi2 build optional for dllStub remove fapi2 from list of header files going to generate_pyecmd.py fix typo fapi2 buffer update enable support for fapi2::Target::reduceType() cipinstruct stop should call spwkup enable before stopping Matt Light (12): Merge pull request ibm-openbmc#260 from thejta/target-hash-support Merge pull request ibm-openbmc#292 from mklight/fix_serverlock Merge pull request ibm-openbmc#299 from shenki/fsi-master-path Merge pull request ibm-openbmc#204 from mklight/BrkptInstruction Merge pull request #328 from mklight/SPIInstruction Merge pull request #340 from mklight/fix_subroutine_rc_check Merge pull request #345 from mklight/remove_relationship Merge pull request ibm-openbmc#2 from fenkes-ibm/fapi2_py_attr Merge pull request #357 from mklight/fapi2_buffer_update Merge pull request #356 from mklight/pyecmd_makefile_update Merge pull request #370 from mklight/reduce_type Merge pull request #376 from mklight/spwkup_cipinstruct_fix Steven Janssen (9): add a mvpd keyword value additional target type added update to getsram to allow passing of a target and additional parameter handling fix a typo for command line processing update buffer methods addition of generici2cslave target information Update version to 14-20 Merge pull request #353 from janssens2/ecmd14_20 Update fsi locations for new bmc code asangram (1): Merge pull request #388 from asangram/updateHtxt sangram alapati (2): updated the help text for stopclocks updated the help text for stopclocks Signed-off-by: Andrew Geissler <geisonator@yahoo.com>
santoshpuranik
pushed a commit
to santoshpuranik/openbmc
that referenced
this pull request
Aug 11, 2021
Currently, machine evb-ast2600 frozed during u-boot booting. This patchset has been tested with AST2600-A1 and AST2600-A3 EVB: AST2600-A1: ``` U-Boot SPL 2019.04 (Jun 16 2021 - 05:59:38 +0000) already initialized, Trying to boot from RAM U-Boot 2019.04 (Jun 16 2021 - 05:59:38 +0000) SOC: AST2600-A1 RST: WDT1 SOC PCI RST: ibm-openbmc#2 LPC Mode: SIO:Enable : SuperIO-2e Eth: MAC0: RGMII, MAC1: RGMII, MAC2: RGMII, MAC3: RGMII Model: AST2600 EVB DRAM: already initialized, 1008 MiB (capacity:1024 MiB, VGA:16 MiB), ECC off MMC: sdhci_slot0@100: 1, sdhci_slot1@200: 2, emmc_slot0@100: 0 Loading Environment from SPI Flash... SF: Detected w25q512jv with page size 256 Bytes, erase size 4 KiB, total 64 MiB OK In: serial@1e784000 ``` AST2600-A3: ``` BP0c00 U-Boot SPL 2019.04 (Jun 16 2021 - 05:59:38 +0000) already initialized, Trying to boot from RAM U-Boot 2019.04 (Jun 16 2021 - 05:59:38 +0000) SOC: AST2600-A3 RST: WDT1 SOC PCI RST: ibm-openbmc#2 eSPI Mode: SIO:Enable : SuperIO-2e Eth: MAC0: RGMII, MAC1: RGMII, MAC2: RGMII, MAC3: RGMII Model: AST2600 EVB DRAM: already initialized, 960 MiB (capacity:1024 MiB, VGA:64 MiB), ECC off MMC: sdhci_slot0@100: 1, sdhci_slot1@200: 2, emmc_slot0@100: 0 Loading Environment from SPI Flash... SF: Detected w25q512jv with page size 256 Bytes, erase size 4 KiB, total 64 MiB OK In: serial@1e784000 ``` Signed-off-by: Troy Lee <troy_lee@aspeedtech.com> Change-Id: I77ec3c2928ca96ee3f51290fd3435fca08bb058a
rfrandse
pushed a commit
that referenced
this pull request
Aug 21, 2021
Alexander Amelkin (5): Merge pull request #2 from YADRO-KNS/feature/ntp-and-dns-per-iface help: Don't display banner in CLI mode Add support for `help` as the first arg of command Add --cli-hide-cmd option Refix c0b47545069ed4a64bf1e1434315657d64ab3c5d Alexander Filippov (9): Add lists of DNS and NTP per interface Fix dhcp settings Fix DNS list modification multiple DNS and NTP servers in one call Remove gateway from IP adding call ip add/del: Make the network mask optional Improve IP comparison ntp: check given hostname Hide tool from unprivileged user Kirill Pakhomov (2): vlan del: catch exception and display error Merge pull request #11 from YADRO-KNS/bugfix/BBMC-372 Change-Id: Ib2a27383f2dadc2033cc62129b75a8b9413280e5 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
rfrandse
pushed a commit
that referenced
this pull request
Oct 18, 2021
After over a year of discussion, Redfish released new power and thermal schemas as part of the Redfish 2020.4 release. These new powersubsystem, thermalsubsystem, fan, powersupply, etc schemas can co-exist with the old power and thermal schemas. The old schemas and the new schemas are controlled by different options. The current plan for bmcweb is: 1. Until the new schemas are all in and tested, as a default, enable the old schemas and disable the new. 2. After the new have been in and tested, enable them. This means the old and new will co-exist if running the defaults. The sensor collection behavior will reflect the new schemas, that is all sensors can be found under the sensor collection. 3. After an OpenBMC release, at a later time, disable the old and add appropriate deprecation. This change here, enabling the new schemas, jumps meta-ibm to #2. This reflects our desire for our Redfish clients to start using the new schemas. Some reasons why the ThermalSubsystem/PowerSubsystem are an improvement on the existing Thermal/Power schemas: 1. They include the latest properties like LocationIndicatorActive. 2. Fans, PowerSupplies, Temperatures were arrays in the old schemas. This was cumbersome and could hit limits of JSON arrays. 3. Large amount of static data mixed with sensor readings, which hurt performance in certain cases. 4. Inconsistent definitions of properties vs newer schemas like Processor and Memory schemas. Reference: https://www.dmtf.org/sites/default/files/standards/documents/DSP0268_2020.4.pdf Tested: Built bmcweb. See the new sensor behavior. Change-Id: I9a698cbc162a331c21c7dc5138000faac6247f9b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
rfrandse
pushed a commit
that referenced
this pull request
Oct 19, 2021
After over a year of discussion, Redfish released new power and thermal schemas as part of the Redfish 2020.4 release. These new powersubsystem, thermalsubsystem, fan, powersupply, etc schemas can co-exist with the old power and thermal schemas. The old schemas and the new schemas are controlled by different options. The current plan for bmcweb is: 1. Until the new schemas are all in and tested, as a default, enable the old schemas and disable the new. 2. After the new have been in and tested, enable them. This means the old and new will co-exist if running the defaults. The sensor collection behavior will reflect the new schemas, that is all sensors can be found under the sensor collection. 3. After an OpenBMC release, at a later time, disable the old and add appropriate deprecation. This change here, enabling the new schemas, jumps meta-ibm to #2. This reflects our desire for our Redfish clients to start using the new schemas. Some reasons why the ThermalSubsystem/PowerSubsystem are an improvement on the existing Thermal/Power schemas: 1. They include the latest properties like LocationIndicatorActive. 2. Fans, PowerSupplies, Temperatures were arrays in the old schemas. This was cumbersome and could hit limits of JSON arrays. 3. Large amount of static data mixed with sensor readings, which hurt performance in certain cases. 4. Inconsistent definitions of properties vs newer schemas like Processor and Memory schemas. Reference: https://www.dmtf.org/sites/default/files/standards/documents/DSP0268_2020.4.pdf Tested: Built bmcweb. See the new sensor behavior. Change-Id: I9a698cbc162a331c21c7dc5138000faac6247f9b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
rfrandse
pushed a commit
that referenced
this pull request
Oct 21, 2021
After over a year of discussion, Redfish released new power and thermal schemas as part of the Redfish 2020.4 release. These new powersubsystem, thermalsubsystem, fan, powersupply, etc schemas can co-exist with the old power and thermal schemas. The old schemas and the new schemas are controlled by different options. The current plan for bmcweb is: 1. Until the new schemas are all in and tested, as a default, enable the old schemas and disable the new. 2. After the new have been in and tested, enable them. This means the old and new will co-exist if running the defaults. The sensor collection behavior will reflect the new schemas, that is all sensors can be found under the sensor collection. 3. After an OpenBMC release, at a later time, disable the old and add appropriate deprecation. This change here, enabling the new schemas, jumps meta-ibm to #2. This reflects our desire for our Redfish clients to start using the new schemas. Some reasons why the ThermalSubsystem/PowerSubsystem are an improvement on the existing Thermal/Power schemas: 1. They include the latest properties like LocationIndicatorActive. 2. Fans, PowerSupplies, Temperatures were arrays in the old schemas. This was cumbersome and could hit limits of JSON arrays. 3. Large amount of static data mixed with sensor readings, which hurt performance in certain cases. 4. Inconsistent definitions of properties vs newer schemas like Processor and Memory schemas. Reference: https://www.dmtf.org/sites/default/files/standards/documents/DSP0268_2020.4.pdf Tested: Built bmcweb. See the new sensor behavior. Change-Id: I9a698cbc162a331c21c7dc5138000faac6247f9b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
rfrandse
added a commit
that referenced
this pull request
Feb 17, 2022
… (#1633) Bruce Mitchell (2): Replace IRC with Discord Use true instead of 1 for a while loop Manojkiran Eda (1): Add OWNERS file Reed Frandsen (1): ensure that /etc/srvcfg-mgr.json is greater than 0 (#2) Joseph Reynolds (1): Add README Patrick Williams (1): build: switch to C++20 Patrik Tesarik (2): meson: switch pkgconfig access method Add subproject directory & wrapper files Change-Id: Ieec77ba23bcf80fd3e8578d3eae59cc782e69cc8
rfrandse
added a commit
that referenced
this pull request
Feb 17, 2022
Brandon Wyman (36): psu-ng: Include STATUS_INPUT in input fault error psu-ng: Make comm fault first checked psu-ng: Use a separate map for required PSUs data psu-ng: Clear the additionalData each loop psu-ng: Detect CML fault psu-ng: Refactor EXPECT calls for PMBus STATUS_* psu-ng: Add code to detect VOUT_OV_FAULT psu-ng: Change fault traces from INFO to ERR psu-ng: Refactor PowerSupply::isFaulted psu-ng: Refactor PMBus expectations helper psu-ng: Add code to detect temperature fault psu-ng: Add in detection of PGOOD fault psu-ng: Add in detection of IOUT_OC fault psu-ng: Add code to detect VOUT_UV_FAULT PMBus: Fix "file" name for STATUS_FANS_1_2 psu-ng: Add in detection of fan faults psu-ng: INFO journal trace when pgoodFault clears psu-ng: Add DEGLITCH_LIMIT, deglitch pgoodFault psu-ng: IBM FN goes to SparePartNumber psu-ng: Add in handling of specific MFR faults psu-ng: gtest cleanup expectation warnings psu-ng: Change pgoodFault type to size_t psu-ng: Refactor clearing fault member variables psu-ng: Refactor MFR fault detection psu-ng: Refactor PGOOD and UNIT_IS_OFF fault psu-ng: Refactor temperature fault detection psu-ng: Refactor CML fault detection psu-ng: Refactor input fault detection psu-ng: Refactor VOUT_OV_FAULT detection psu-ng: Refactor IOUT_OC_FAULT detection psu-ng: Refactor VOUT_UV_FAULT detection psu-ng: Refactor fan fault detection psu-ng: Refactor VIN_UV fault detection psu-ng: Clear faults when voltage back in range psu-ng: De-glitch all faults psu-ng: Continue reading after readFail Shawn McCarney (16): regulators: Treat missing VPD keyword as empty regulators: Allow empty expected VPD value Add retry support to I2CInterface regulators: Retry failed I2C operations regulators: Enhance additional error data capture ibm-ups: Initial version of UPS application (#1) ibm-ups: Add --no-poll command line option ibm-ups: Poll UPS device for current status ibm-ups: Initial version of UPS application (#1) ibm-ups: Add ObjectManager interface ibm-ups: Add error logging ibm-ups: Initial version of UPS application (#1) ibm-ups: Add --no-poll command line option ibm-ups: Poll UPS device for current status ibm-ups: Add ObjectManager interface ibm-ups: Add error logging Adriana Kobylak (9): Update MAINTAINERS, add OWNERS psu-ng: Change the GPIOReader class to GPIOInterface psu-ng: Implement gpio write function psu-ng: Move model validation to its own function psu-ng: Get the power config full load property psu-ng: Set the power-config-full-load GPIO psu-ng: Run validation when PSU is plugged psu-ng: Check if mismatched PSU is supported psu-ng: Log error on brownout condition Reed Frandsen (4): Merge branch '1020' into master-930458c Merge pull request #2 from smccarney/ibm-ups Merge pull request #3 from smccarney/ibm-ups Merge branch '1020' into master-8b150f3 Patrick Williams (1): sdbusplus: remove usage of deprecated alias Ben Tyner (1): phosphor-power-supply: Populate RT VPD Keywords Jim Wright (14): pseq: Add two second wait to power off pseq: Call chassis hard power off on pgood fail pseq: Add logging of power on/off timeout entries pseq: Retrieve device info from entity manager pseq: Add base and UCD90320 device monitor classes pseq: Retrieve compatible systems from EM pseq: Find and parse configuaration file pseq: Add setPowerSupplyError D-Bus method pseq: Setup UCD90320 device GPIOs pseq: Add generic failure handling to base class pseq: Add UCD90320 specific error handling pseq: Add Rainier configuration file pseq: Add service file pseq: Add Everest configuration file Change-Id: I7bc783e7d1c91904391ed8f145c5bcb9782d031f
rfrandse
pushed a commit
to rfrandse/openbmc-1
that referenced
this pull request
Jul 18, 2022
Shantappa Teekappanavar (1): Block host IPLing when BMC is not ready (ibm-openbmc#2) Change-Id: I757f30de39f341572806b189560e629a826ca04a
rfrandse
pushed a commit
to rfrandse/openbmc-1
that referenced
this pull request
Jul 18, 2022
Shantappa Teekappanavar (1): Block host IPLing when BMC is not ready (ibm-openbmc#2) Change-Id: I757f30de39f341572806b189560e629a826ca04a
rfrandse
pushed a commit
that referenced
this pull request
Jul 18, 2022
Shantappa Teekappanavar (1): Block host IPLing when BMC is not ready (#2) Change-Id: I757f30de39f341572806b189560e629a826ca04a
rfrandse
added a commit
that referenced
this pull request
Oct 25, 2022
Marri Devender Rao (2): libipl: perform setup ref clock only on primary processor libipl: perform clock test only on primary processor Reed Frandsen (1): Merge pull request #2 from devenrao/1020 Change-Id: If7739bb8999d62d2aad011d0d668557ace186b43
rfrandse
pushed a commit
that referenced
this pull request
Oct 26, 2022
Shantappa Teekappanavar (1): Block host IPLing when BMC is not ready (#2) Change-Id: I757f30de39f341572806b189560e629a826ca04a
rfrandse
added a commit
that referenced
this pull request
Oct 26, 2022
Marri Devender Rao (2): libipl: perform setup ref clock only on primary processor libipl: perform clock test only on primary processor Reed Frandsen (1): Merge pull request #2 from devenrao/1020 Change-Id: If7739bb8999d62d2aad011d0d668557ace186b43
rfrandse
added a commit
that referenced
this pull request
Nov 3, 2022
sandeepasingh116 (15): Add new toggles on CM page (#3) Changed connection status logic for Hypervisor console (#6) Remove dump download option from overview page (#9) Add text on user management page (#8) Rename the save setting button (#20) Add success toast (#18) Fix network eth1 error (#21) Disable date and time page (#24) Update password helptext (#19) Add info tooltip to frequency cap (#25) Read only user will not be able to toggle switches (#28) Make filters translatable (#33) Fix translations of vet capabilities (#35) fix english texts containing links (#38) Remove service login label for read only user (#45) Sandeepa Singh (9): Update Automatic helptext (#340) Grey out toggle when DHCP is disabled (#338) Disable delete when system is powered on (#327) Renamed added optimization page (#346) Fix deconfiguration record translation bug (#360) Fix power page translation bug (#361) Operating mode is translatable now (#363) Fix user management page translation bugs (#365) Fix server power ops translation bugs (#359) A Nikhil (4): PCIe topology performance improved (#337) AIX/LINUX and IBM i partition are only for non-HMC manage system (#318) Severity values is now translatable (#357) Enabled value taken from translation file (#362) Kenneth Fullbright (4): Created real time indicator postCodeValue filter (#302) Fixed Deconfig table download additional data button (#328) Changed page "Lateral cast out" to "Added optimization" (#341) Added notices page (#336) Nikhil Ashoka (26): pdated the text of server power ops documentation (#7) Displaying Sensors table one row at a time (#11) NTP server duplicate entry is not accepted (#4) Fabric Adapters Info in Inventory page (#12) Fixed Secure LDAP using SSL checkbox value (#2) Added progress bar for activate access key (#1) Error message displayed if fails to authenticate the user (#10) Memory page made HMC-managed independent (#15) Sorting fixed for status (#17) Sensors table now updating on refresh (#22) Secure LDAP is disabled when LDAP authentication disables (#23) Removed Service consoles page for read-only users (#14) Additional message added on Disable SSH (#30) Default partition value taken from translation file (#36) Updated password Max Limit (#26) New Error message displayed if fails to authenticate the user (#27) Added Status and roles values to the translation file (#31) Title translation (#34) Power values added to translation file (#32) Health and Date format taken from translation file (#37) Added possible property values in translation file (#39) Displaying System Anchor value (#40) Added Info tooltip to VirtualTPM (#47) Added max limit based on selected user (#46) Refresh only once after login (#42) Lamp test switch disabled once ON (#48) Change-Id: I1b9ec6fb45503c445cb533a6043f4b81fa4bdf38
rfrandse
added a commit
that referenced
this pull request
Nov 28, 2022
Glukhov Mikhail (1): Fix tar error when packing files Adriana Kobylak (6): updater: Use fw_printenv to restore field mode (#20) usb: Automatically reboot and update both sides Merge pull request #2 from zamiseck/sync-1030 image_manager: Add check for IBM extended version format image_manager: Add check for IBM extended version format (#3) Merge pull request #5 from anoo1/1030-reboot-guard-dep Reed Frandsen (1): Merge pull request #4 from zamiseck/symlink-tmp Patrick Williams (1): MAINTAINERS: remove file Andrew Geissler (1): ensure disable of reboot occurs after enable Zami Seck (5): Initiate Dump After Code Update Failure (#27) Add Progress Code For USB Code Update (#31) Ensure /tmp/images/ Directory Does Not Fill Up (#32) USB Code Update: Cleanup (#39) Ensure only one code update occurs at a time (#33) zamiseck (2): Symlink /tmp/images/ Directory To Allow For More Storage Clear /tmp/images/ Directory Upon Reboot Change-Id: Ia5218c61d89fc9dc0dc6321d14a8e5c8d3e93562
rfrandse
added a commit
that referenced
this pull request
Nov 28, 2022
Glukhov Mikhail (1): Fix tar error when packing files Adriana Kobylak (6): updater: Use fw_printenv to restore field mode (#20) usb: Automatically reboot and update both sides Merge pull request #2 from zamiseck/sync-1030 image_manager: Add check for IBM extended version format image_manager: Add check for IBM extended version format (#3) Merge pull request #5 from anoo1/1030-reboot-guard-dep Reed Frandsen (1): Merge pull request #4 from zamiseck/symlink-tmp Patrick Williams (1): MAINTAINERS: remove file Andrew Geissler (1): ensure disable of reboot occurs after enable Zami Seck (5): Initiate Dump After Code Update Failure (#27) Add Progress Code For USB Code Update (#31) Ensure /tmp/images/ Directory Does Not Fill Up (#32) USB Code Update: Cleanup (#39) Ensure only one code update occurs at a time (#33) zamiseck (2): Symlink /tmp/images/ Directory To Allow For More Storage Clear /tmp/images/ Directory Upon Reboot Change-Id: Ia5218c61d89fc9dc0dc6321d14a8e5c8d3e93562
rfrandse
added a commit
that referenced
this pull request
Jan 3, 2023
Sandeepa Singh (47): Firmware-change (#66) Allow only tar file upload (#71) Hardware Deconfiguration Page (#84) Deconfig-Toggles (#110) Filter SNMP data (#112) Upload acf certificate on login page (#126) Hardware deconfiguration fix (#128) TFTP firmware update (#104) Add filter to remove absent dimms form GUI (#139) Add abiliy to sort hardware deconfig columns (#162) Add helptext for FQDN (#164) Add deconfiguration type as None (#163) Fix link to deconfiguration records (#155) Remove regex from firmware (#151) Add alert for HMC connection disconnect (#152) Update hardware deconfiguration per Demo feedback (#180) Remove Default option from Server power operations page (#188) reverting removal of Default partition environment dropdown (#190) Add Lateral cast out page (#177) fix toggle issue (#191) Add details on login page (#193) Remove TFTP server option from firmware page (#194) Real time post codes converted to ASCII (#207) fix TFTP bug (#213) Show/Hide ACF upload button (#214) Fix toggle issue (#219) Change the toggle text to configure/deconfigure (#223) Fix the sorting issue in progress logs (#240) Translate severity to fatal,predictive and manual (#235) Add Pel ID column on HW deconfiguration page (#244) Show FW_boot_side_current attribute value (#262) Added filter to remove 00000000 from post code table (#272) Fix toast msg for HW deconfiguration page (#251) Add location code of Deconfig records page (#293) Make memory page consistent (#308) Add pel id column (#332) Update service login condition (#326) Edit app nav and login file (#335) Update Automatic helptext (#340) Grey out toggle when DHCP is disabled (#338) Disable delete when system is powered on (#327) Renamed added optimization page (#346) Fix deconfiguration record translation bug (#360) Fix power page translation bug (#361) Operating mode is translatable now (#363) Fix user management page translation bugs (#365) Fix server power ops translation bugs (#359) Kenneth Fullbright (85): Removed irrelevant fields from the VET Capabilities table (#68) Update Firmware page interactions when system is powered on (#51) Updated CSR Modal & Service login Certificate Modal (#59) Removed OemIBMServiceAgent from Group Privilege list (#76) Updated Power saver modes descriptions (#83) Popup SOL Console (Host Console) not showing correct connection status (#79) Removed irrelevant fields from the VET Capabilities table (#93) Added Initiate Resource Dump Function (#103) Fixed password change/reset code for expired password (#125) Fixed global action vuex error getUsers (#120) Fixed 'Promise.all' related errors on Overview (#119) Renamed "Serial over LAN (SOL) console" page (#54) Fixed event log table to be fully responsive (#122) Prevent service user password change (#88) Turned dumps PHYP alert into a toast (#140) Repaired Service login consoles links in the navbar (#145) Removed LDAP from navigation on non admin role accounts (#108) Updated the link to consoles and other nav related items Refactored Power page and power page related things (#109) Added Power restore policy missing alert on operating mode manual (#147) Made non-service roles not pass default password for resource dumps (#135) Fixed BMC Hypervisor console switch (#159) Enhanced user creation and current user failed message for password change (#81) Fixed translation double key error (#146) Removed service privilege option from edit user and add user (#161) Enhanced resource dump error messages (#168) Refactored Power page code for efficiency and clarity (#158) Fixed init system dump from resource dump (#136) Added toast for invalid privilege (#172) Fixed Service consoles (#176) Fix user management delete table action (#179) Fixed service account resource dumps password field to allow any string (#183) Fixed Idle power saving missing reset button option (#184) Removed lower and upper limit and warning sensors (#186) Fixed missing fields for add user on user modal (#185) Fixed maximum amount of users toast error (#196) Fixed delete and replace function in Certificates table (#197) Fixed navbar missing error (#206) Fixed popup BMC and Hypervisor consoles. (#205) Fixed init system dump PHYP in standby check error (#204) Fixed closing console conntections. (#220) Fixed upload certificate button not being disabled on max certificates (#224) Added info tool tips on password changing fields. (#225) Removed operator role from add role group modal (#229) [SW550540] Removed Operator and NoAccess roles from desciption table (#228) [SW550558] Fixed proxy logout error (#226) Created info icon for enhanced information about power consumption (#232) Fixed some tables not being fully responsive (#222) Set autocomplete option to off for password fields (#231) Added dump being offloaded warning for reboot and shutdown (#241) Fixed system dump error messages (#238) Fixed factory reset to default code (#243) Changed OemIBMServiceAgent to ServiceAgent (#261) Add safe mode to user interface (#250) Fixed fresh install set password and login error (#263) Fixed DHCP delete button not disabled (#273) Removed unsupported ServiceAgent group from LDAP group privilege modal (#268) Fixed Zombie state when factory resetting (#270) Fixed unauthorized error toast on page loading (#267) Fixed firmware swapping confusion (#271) Fixed console connection indicators (#275) Fixed account polocy settings displaying not updated info on refresh (#276) Fixed running and backup image info render problem (#287) Fixed event logs not updating upon delete all button (#290) Fixed account policy radio buttons (#289) Fixed secure LDAP checkbox not showing correct values (#291) Fixed firmware update function (#296) Fixed JSON.parse error from localStorage (#298) Fixed factory reset function to be fully async (#306) Removed host console access from ReadOnly roles (#307) Fixed SRC Details not showing on non manual records (#300) Fixed page memory validation error (#313) Fixed location code not showing on Deconfiguration records table (#317) Disabled users from changing username on user management table (#321) Added Location codes for TPM (#324) Fixed console indicators not updating status (#304) Added Location codes for TPM (#325) Made more meaningful toasts (#314) Fixed manage access keys hyperlink being disabled problems on Firmware page (#322) Fixed asset tag info not showing up in modal after app refresh and tag update (#333) Removed hashes from files (#334) Created real time indicator postCodeValue filter (#302) Fixed Deconfig table download additional data button (#328) Changed page "Lateral cast out" to "Added optimization" (#341) Added notices page (#336) A Nikhil (47): Update Inventory DIMM table (#74) Update Inventory Assemblies table (#87) Update Inventory Processors table (#86) Incorrect Power mode value (#89) Dumps available on BMC are not displayed on BMC-GUI (#72) Components on the hardware page not in order (#101) No values populated for licensed and configured cores (#91) Update GUI as IBM (#116) Rename Update Firmware access key (#117) Health and state field of assembly components is missing in inventory page (#99) Event logs add missing information (#111) GUI has no way to turn off System attention LED (#129) Event log does not show information for service (#133) GUI missing detailed COD (#124) Rename count in system table (#149) FCO page accepts value greater than the number of licensed cores (#142) Part number field is showing spare part number value (#165) Wrong lable on SRC for logs (#156) Inventory and LEDs page has two system entries (#137) Add toggle to enable/disable the secure version lock in (#167) Factory reset option should only be provided at power off (#174) Health in critical state after marking critical errors as resolved (#189) Concurrent maintenance Page (#202) Download implementation in Event logs (#192) Missing host USB enable/disable (#239) Prevent system power on when BMC is not in Ready state (#227) Adding mex chassis Info (#233) Mex IO enclosure firmware version not displayed (#265) PCIe Hardware Topology (#181) Warning in PcieTopology.vue (#282) Pcie-topology and Inventory fixes (#288) Unable to edit group name in the Add Role group field. (#303) PCIe Topology Save changes (#309) Invalid range for I/O Adapter enlarged capacity (#311) Status for both system and chassis comes as absent at host power off state (#312) Status for system table should be Present (#320) Fixed Identify LED error in MEX chassis (#330) Assemblies section does not has search option in Inventory page (#315) PCIe link width for empty slots is showing as -1 (#319) Warning message only in manual mode (#323) Fixed incorrect Identity LEDs error message (#331) Unwanted fields for MEX components removed (#329) PCIe topology performance improved (#337) AIX/LINUX and IBM i partition are only for non-HMC manage system (#318) Severity values is now translatable (#357) Enabled value taken from translation file (#362) Removed .tar.xz extension from dumps (#410) whitesource-ets[bot] (1): Add .whitesource configuration file sandeepasingh116 (17): Add new toggles on CM page (#3) Changed connection status logic for Hypervisor console (#6) Remove dump download option from overview page (#9) Add text on user management page (#8) Rename the save setting button (#20) Add success toast (#18) Fix network eth1 error (#21) Disable date and time page (#24) Update password helptext (#19) Add info tooltip to frequency cap (#25) Read only user will not be able to toggle switches (#28) Make filters translatable (#33) Fix translations of vet capabilities (#35) fix english texts containing links (#38) Remove service login label for read only user (#45) fix translation defect for server power ops (#52) add toogle on Policies page (#73) Reed Frandsen (1): Removed alert message from Update firmware component (#90) Gunnar Mills (3): Enable hmc proxy (#208) Update notices to 1030 (#50) Revert "Refresh only once after login (#42)" (#59) Nikhil Ashoka (33): pdated the text of server power ops documentation (#7) Displaying Sensors table one row at a time (#11) NTP server duplicate entry is not accepted (#4) Fabric Adapters Info in Inventory page (#12) Fixed Secure LDAP using SSL checkbox value (#2) Added progress bar for activate access key (#1) Error message displayed if fails to authenticate the user (#10) Memory page made HMC-managed independent (#15) Sorting fixed for status (#17) Sensors table now updating on refresh (#22) Secure LDAP is disabled when LDAP authentication disables (#23) Removed Service consoles page for read-only users (#14) Additional message added on Disable SSH (#30) Default partition value taken from translation file (#36) Updated password Max Limit (#26) New Error message displayed if fails to authenticate the user (#27) Added Status and roles values to the translation file (#31) Title translation (#34) Power values added to translation file (#32) Health and Date format taken from translation file (#37) Added possible property values in translation file (#39) Displaying System Anchor value (#40) Added Info tooltip to VirtualTPM (#47) Added max limit based on selected user (#46) Refresh only once after login (#42) Lamp test switch disabled once ON (#48) Tab names translated in Inventory page (#54) Using privilege values from the translation file (#56) Deconfiguration type is taken from translation file (#57) Fabric Adapter table showing Name (#55) PCIe topology overlapping fix (#53) Added Identity LED to Fabric Adapters (#49) Removed Error message from Accounts verification (#44) Dixsie Wolmers (14): Fix network settings defects - FQDN, link info, and MAC address (#113) Audit translation file (#115) Network settings - update DHCP section (#114) Add deconfiguration logs page (#121) Fix host console route (#157) Fix language dropdown on login page (#166) Network settings fixes - dhcp modal, edit ipv4, default gateway (#175) Update deconfig log table (#200) Update network settings ipv4 table (#199) Fix network settings hostname and IUM errors (#210) Add ability to edit asset tag (#211) Fix LDAP form values when LDAP disabled - SW546990 (#245) Fix deconfig records defects (#246) Update maintainers - Remove Dixsie and add Sandeepa (#286) aixt9n aixt9n (2): i18n: KO_KR: Drop latest translated files for webui-vue (#257) i18n: ES_ES: Drop latest translated files for webui-vue (#258) Change-Id: Ib5cb6cfccace5b718d22173ff1df4e8ce2a1e05c
rfrandse
added a commit
that referenced
this pull request
Mar 28, 2024
Sandeepa Singh (47): Firmware-change (#66) Allow only tar file upload (#71) Hardware Deconfiguration Page (#84) Deconfig-Toggles (#110) Filter SNMP data (#112) Upload acf certificate on login page (#126) Hardware deconfiguration fix (#128) TFTP firmware update (#104) Add filter to remove absent dimms form GUI (#139) Add abiliy to sort hardware deconfig columns (#162) Add helptext for FQDN (#164) Add deconfiguration type as None (#163) Fix link to deconfiguration records (#155) Remove regex from firmware (#151) Add alert for HMC connection disconnect (#152) Update hardware deconfiguration per Demo feedback (#180) Remove Default option from Server power operations page (#188) reverting removal of Default partition environment dropdown (#190) Add Lateral cast out page (#177) fix toggle issue (#191) Add details on login page (#193) Remove TFTP server option from firmware page (#194) Real time post codes converted to ASCII (#207) fix TFTP bug (#213) Show/Hide ACF upload button (#214) Fix toggle issue (#219) Change the toggle text to configure/deconfigure (#223) Fix the sorting issue in progress logs (#240) Translate severity to fatal,predictive and manual (#235) Add Pel ID column on HW deconfiguration page (#244) Show FW_boot_side_current attribute value (#262) Added filter to remove 00000000 from post code table (#272) Fix toast msg for HW deconfiguration page (#251) Add location code of Deconfig records page (#293) Make memory page consistent (#308) Add pel id column (#332) Update service login condition (#326) Edit app nav and login file (#335) Update Automatic helptext (#340) Grey out toggle when DHCP is disabled (#338) Disable delete when system is powered on (#327) Renamed added optimization page (#346) Fix deconfiguration record translation bug (#360) Fix power page translation bug (#361) Operating mode is translatable now (#363) Fix user management page translation bugs (#365) Fix server power ops translation bugs (#359) Kenneth Fullbright (85): Removed irrelevant fields from the VET Capabilities table (#68) Update Firmware page interactions when system is powered on (#51) Updated CSR Modal & Service login Certificate Modal (#59) Removed OemIBMServiceAgent from Group Privilege list (#76) Updated Power saver modes descriptions (#83) Popup SOL Console (Host Console) not showing correct connection status (#79) Removed irrelevant fields from the VET Capabilities table (#93) Added Initiate Resource Dump Function (#103) Fixed password change/reset code for expired password (#125) Fixed global action vuex error getUsers (#120) Fixed 'Promise.all' related errors on Overview (#119) Renamed "Serial over LAN (SOL) console" page (#54) Fixed event log table to be fully responsive (#122) Prevent service user password change (#88) Turned dumps PHYP alert into a toast (#140) Repaired Service login consoles links in the navbar (#145) Removed LDAP from navigation on non admin role accounts (#108) Updated the link to consoles and other nav related items Refactored Power page and power page related things (#109) Added Power restore policy missing alert on operating mode manual (#147) Made non-service roles not pass default password for resource dumps (#135) Fixed BMC Hypervisor console switch (#159) Enhanced user creation and current user failed message for password change (#81) Fixed translation double key error (#146) Removed service privilege option from edit user and add user (#161) Enhanced resource dump error messages (#168) Refactored Power page code for efficiency and clarity (#158) Fixed init system dump from resource dump (#136) Added toast for invalid privilege (#172) Fixed Service consoles (#176) Fix user management delete table action (#179) Fixed service account resource dumps password field to allow any string (#183) Fixed Idle power saving missing reset button option (#184) Removed lower and upper limit and warning sensors (#186) Fixed missing fields for add user on user modal (#185) Fixed maximum amount of users toast error (#196) Fixed delete and replace function in Certificates table (#197) Fixed navbar missing error (#206) Fixed popup BMC and Hypervisor consoles. (#205) Fixed init system dump PHYP in standby check error (#204) Fixed closing console conntections. (#220) Fixed upload certificate button not being disabled on max certificates (#224) Added info tool tips on password changing fields. (#225) Removed operator role from add role group modal (#229) [SW550540] Removed Operator and NoAccess roles from desciption table (#228) [SW550558] Fixed proxy logout error (#226) Created info icon for enhanced information about power consumption (#232) Fixed some tables not being fully responsive (#222) Set autocomplete option to off for password fields (#231) Added dump being offloaded warning for reboot and shutdown (#241) Fixed system dump error messages (#238) Fixed factory reset to default code (#243) Changed OemIBMServiceAgent to ServiceAgent (#261) Add safe mode to user interface (#250) Fixed fresh install set password and login error (#263) Fixed DHCP delete button not disabled (#273) Removed unsupported ServiceAgent group from LDAP group privilege modal (#268) Fixed Zombie state when factory resetting (#270) Fixed unauthorized error toast on page loading (#267) Fixed firmware swapping confusion (#271) Fixed console connection indicators (#275) Fixed account polocy settings displaying not updated info on refresh (#276) Fixed running and backup image info render problem (#287) Fixed event logs not updating upon delete all button (#290) Fixed account policy radio buttons (#289) Fixed secure LDAP checkbox not showing correct values (#291) Fixed firmware update function (#296) Fixed JSON.parse error from localStorage (#298) Fixed factory reset function to be fully async (#306) Removed host console access from ReadOnly roles (#307) Fixed SRC Details not showing on non manual records (#300) Fixed page memory validation error (#313) Fixed location code not showing on Deconfiguration records table (#317) Disabled users from changing username on user management table (#321) Added Location codes for TPM (#324) Fixed console indicators not updating status (#304) Added Location codes for TPM (#325) Made more meaningful toasts (#314) Fixed manage access keys hyperlink being disabled problems on Firmware page (#322) Fixed asset tag info not showing up in modal after app refresh and tag update (#333) Removed hashes from files (#334) Created real time indicator postCodeValue filter (#302) Fixed Deconfig table download additional data button (#328) Changed page "Lateral cast out" to "Added optimization" (#341) Added notices page (#336) A Nikhil (47): Update Inventory DIMM table (#74) Update Inventory Assemblies table (#87) Update Inventory Processors table (#86) Incorrect Power mode value (#89) Dumps available on BMC are not displayed on BMC-GUI (#72) Components on the hardware page not in order (#101) No values populated for licensed and configured cores (#91) Update GUI as IBM (#116) Rename Update Firmware access key (#117) Health and state field of assembly components is missing in inventory page (#99) Event logs add missing information (#111) GUI has no way to turn off System attention LED (#129) Event log does not show information for service (#133) GUI missing detailed COD (#124) Rename count in system table (#149) FCO page accepts value greater than the number of licensed cores (#142) Part number field is showing spare part number value (#165) Wrong lable on SRC for logs (#156) Inventory and LEDs page has two system entries (#137) Add toggle to enable/disable the secure version lock in (#167) Factory reset option should only be provided at power off (#174) Health in critical state after marking critical errors as resolved (#189) Concurrent maintenance Page (#202) Download implementation in Event logs (#192) Missing host USB enable/disable (#239) Prevent system power on when BMC is not in Ready state (#227) Adding mex chassis Info (#233) Mex IO enclosure firmware version not displayed (#265) PCIe Hardware Topology (#181) Warning in PcieTopology.vue (#282) Pcie-topology and Inventory fixes (#288) Unable to edit group name in the Add Role group field. (#303) PCIe Topology Save changes (#309) Invalid range for I/O Adapter enlarged capacity (#311) Status for both system and chassis comes as absent at host power off state (#312) Status for system table should be Present (#320) Fixed Identify LED error in MEX chassis (#330) Assemblies section does not has search option in Inventory page (#315) PCIe link width for empty slots is showing as -1 (#319) Warning message only in manual mode (#323) Fixed incorrect Identity LEDs error message (#331) Unwanted fields for MEX components removed (#329) PCIe topology performance improved (#337) AIX/LINUX and IBM i partition are only for non-HMC manage system (#318) Severity values is now translatable (#357) Enabled value taken from translation file (#362) Removed .tar.xz extension from dumps (#410) whitesource-ets[bot] (1): Add .whitesource configuration file sandeepasingh116 (17): Add new toggles on CM page (#3) Changed connection status logic for Hypervisor console (#6) Remove dump download option from overview page (#9) Add text on user management page (#8) Rename the save setting button (#20) Add success toast (#18) Fix network eth1 error (#21) Disable date and time page (#24) Update password helptext (#19) Add info tooltip to frequency cap (#25) Read only user will not be able to toggle switches (#28) Make filters translatable (#33) Fix translations of vet capabilities (#35) fix english texts containing links (#38) Remove service login label for read only user (#45) fix translation defect for server power ops (#52) add toogle on Policies page (#73) Reed Frandsen (1): Removed alert message from Update firmware component (#90) Gunnar Mills (3): Enable hmc proxy (#208) Update notices to 1030 (#50) Revert "Refresh only once after login (#42)" (#59) Nikhil Ashoka (33): pdated the text of server power ops documentation (#7) Displaying Sensors table one row at a time (#11) NTP server duplicate entry is not accepted (#4) Fabric Adapters Info in Inventory page (#12) Fixed Secure LDAP using SSL checkbox value (#2) Added progress bar for activate access key (#1) Error message displayed if fails to authenticate the user (#10) Memory page made HMC-managed independent (#15) Sorting fixed for status (#17) Sensors table now updating on refresh (#22) Secure LDAP is disabled when LDAP authentication disables (#23) Removed Service consoles page for read-only users (#14) Additional message added on Disable SSH (#30) Default partition value taken from translation file (#36) Updated password Max Limit (#26) New Error message displayed if fails to authenticate the user (#27) Added Status and roles values to the translation file (#31) Title translation (#34) Power values added to translation file (#32) Health and Date format taken from translation file (#37) Added possible property values in translation file (#39) Displaying System Anchor value (#40) Added Info tooltip to VirtualTPM (#47) Added max limit based on selected user (#46) Refresh only once after login (#42) Lamp test switch disabled once ON (#48) Tab names translated in Inventory page (#54) Using privilege values from the translation file (#56) Deconfiguration type is taken from translation file (#57) Fabric Adapter table showing Name (#55) PCIe topology overlapping fix (#53) Added Identity LED to Fabric Adapters (#49) Removed Error message from Accounts verification (#44) Dixsie Wolmers (14): Fix network settings defects - FQDN, link info, and MAC address (#113) Audit translation file (#115) Network settings - update DHCP section (#114) Add deconfiguration logs page (#121) Fix host console route (#157) Fix language dropdown on login page (#166) Network settings fixes - dhcp modal, edit ipv4, default gateway (#175) Update deconfig log table (#200) Update network settings ipv4 table (#199) Fix network settings hostname and IUM errors (#210) Add ability to edit asset tag (#211) Fix LDAP form values when LDAP disabled - SW546990 (#245) Fix deconfig records defects (#246) Update maintainers - Remove Dixsie and add Sandeepa (#286) aixt9n aixt9n (2): i18n: KO_KR: Drop latest translated files for webui-vue (#257) i18n: ES_ES: Drop latest translated files for webui-vue (#258) Change-Id: Ib5cb6cfccace5b718d22173ff1df4e8ce2a1e05c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Geissler geissonator@yahoo.com