Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate towards spawn instead of exec #48

Closed
quinnturner opened this issue Jan 30, 2019 · 1 comment · Fixed by #60
Closed

Migrate towards spawn instead of exec #48

quinnturner opened this issue Jan 30, 2019 · 1 comment · Fixed by #60

Comments

@quinnturner
Copy link
Member

See comments in #47 for more information regarding the decision behind using spawn instead of exec.

I have had difficulties in the past with spawn for displaying inappropriate errors due to uncaught exceptions (or rejections) in a Promise (see #45). That issue should be addressed, along with the spawn migration, in the same PR. Some work can also be done for #39.
@quinnturner
Copy link
Member Author

Addressed in #53

@quinnturner quinnturner mentioned this issue Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release): Minor bump to 1.4.0 quinnturner/audit-ci
1 participant
@quinnturner