-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return exit codes based on validation #65
Comments
This is definitely the desired behaviour 👍 |
IMO it would be best if we returned the exit code received from the original audit unless the exit code was non-zero due to a vulnerability that is whitelisted or below the specified level. This handles cases of other potential codes such as codes related to network errors, invalid registry, etc. At a minimum, it should return 1 if there's a non-whitelisted vulnerability above the level specified. |
Um.. Are you sure that is the case? I mean the whole idea of the wrapper is for it to fail
in a CI environment,which basically means it returns a non-zero exit-code. I am pretty sure that's exactly what's happening. |
Sorry I was wrong. When it fails it returns exit code of 1. When it passed, it returns 0. To verify this, run the |
Currently exit code 0 is always returned no matter whether there are vulnerabilities or not. Can you add that? Thanks
The text was updated successfully, but these errors were encountered: