You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched the issues and found no similar issues.
Component
Transforms/universal/noop
Feature
Clarity requested by Dean in: data-prep-kit/transforms/universal/noop/README.md
Can you provide more explanation about what the configuration values, do, e.g.,
• noop_sleep_sec : specifies the number of seconds to sleep during table transformation. What does "during" mean. Is it really before or after processing starts? Is this something "real" transformers might want, e.g., to allow something to happen in the background before reading starts?
• noop_pwd - specifies a dummy password not included in metadata. I assume this is for accessing the file. Is a user name also required?
Of course, you said these are examples, but I would go to extra effort to clarify specific behaviors, to encourage users to do the same.
As a general note about configuration parameter names, would it be better to use a hierarchy, like noop.sleep.sec so that in the noop context, you would just look at sleep.sec in the config file. I made sleep a parent in case you added more options, e.g.,
noop.sleep.enable = false
noop.sleep.sec = 2
Are you willing to submit a PR?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered:
Search before asking
Component
Transforms/universal/noop
Feature
Clarity requested by Dean in: data-prep-kit/transforms/universal/noop/README.md
Can you provide more explanation about what the configuration values, do, e.g.,
• noop_sleep_sec : specifies the number of seconds to sleep during table transformation. What does "during" mean. Is it really before or after processing starts? Is this something "real" transformers might want, e.g., to allow something to happen in the background before reading starts?
• noop_pwd - specifies a dummy password not included in metadata. I assume this is for accessing the file. Is a user name also required?
Of course, you said these are examples, but I would go to extra effort to clarify specific behaviors, to encourage users to do the same.
As a general note about configuration parameter names, would it be better to use a hierarchy, like noop.sleep.sec so that in the noop context, you would just look at sleep.sec in the config file. I made sleep a parent in case you added more options, e.g.,
noop.sleep.enable = false
noop.sleep.sec = 2
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: