Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smart-configuration properties in default fhir-server-config conflict with property constants #1589

Closed
lmsurpre opened this issue Oct 16, 2020 · 0 comments
Closed

smart-configuration properties in default fhir-server-config conflict with property constants #1589

lmsurpre opened this issue Oct 16, 2020 · 0 comments
Assignees
@lmsurpre
Labels
bug Something isn't working
Milestone
Sprint 19

Comments

@lmsurpre
Copy link
Member

Describe the bug
After upgrading to 4.4.1, I navigated to [base]/.well-known/smart-configuration
and noticed that all the smart-configuration data is missing.

To Reproduce
Steps to reproduce the behavior:

  1. deploy 4.4.1
  2. enable fhirServer/security/oauth/smart
  3. navigate to the [base]/.well-known/smart-configuration endpoint

Expected behavior
The default config should work

Additional context
N/A
@lmsurpre lmsurpre added the bug Something isn't working label Oct 16, 2020
@lmsurpre lmsurpre added this to the Sprint 19 milestone Oct 16, 2020
@lmsurpre lmsurpre self-assigned this Oct 16, 2020
lmsurpre added a commit that referenced this issue Oct 16, 2020
@lmsurpre
issue #1589 - fix FHIRConfiguration smart properties
095513e 
and add `fhirServer/security/oauth/smart/capabilities` to the docs

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 20, 2020
@lmsurpre
Add tests for issues #1589 and #1449
d9a94e2 
We don't make it very easy to add component-level tests for our rest
layer.  This pull request works with what we have to test the public
JAX-RS methods for building the CapabilityStatement resource and the
smart-configuration JSON from various configs.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 20, 2020
@lmsurpre
Add tests for issues #1589 and #1449
ce32f11 
We don't make it very easy to add component-level tests for our rest
layer.  This pull request works with what we have to test the public
JAX-RS methods for building the CapabilityStatement resource and the
smart-configuration JSON from various configs.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 20, 2020
@lmsurpre
Add tests for issues #1589 and #1449
469812e 
We don't make it very easy to add component-level tests for our rest
layer.  This pull request works with what we have to test the public
JAX-RS methods for building the CapabilityStatement resource and the
smart-configuration JSON from various configs.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 19
Development

No branches or pull requests
1 participant
@lmsurpre