Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mockbroker.go should not import testing #66

Closed
dolzenko opened this issue Jan 24, 2014 · 1 comment
Closed

mockbroker.go should not import testing #66

dolzenko opened this issue Jan 24, 2014 · 1 comment

Comments

@dolzenko
Copy link

Currently any lib importing Shopify/sarama will get "testing" package pulled in. According to nice folks at #go-nuts "testing" package should be imported only from *_test.go.
@eapache eapache added the bug label Jun 24, 2014
@eapache
Copy link
Contributor

eapache commented Jun 26, 2014

This was fixed by #64

@eapache eapache closed this as completed Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dolzenko @eapache