Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kiel ]Make DSL ViewBinding supported #36

Open
ibrahimyilmaz opened this issue Aug 5, 2020 · 8 comments
Open

[kiel ]Make DSL ViewBinding supported #36

ibrahimyilmaz opened this issue Aug 5, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ibrahimyilmaz
Copy link
Owner

Now kiel gets layoutId but it will also be nice to support ViewBinding instead of layoutId.

@ibrahimyilmaz ibrahimyilmaz changed the title Support for ViewBinding classes Make DSL ViewBinding supported Aug 5, 2020
@ibrahimyilmaz ibrahimyilmaz added enhancement New feature or request good first issue Good for newcomers labels Aug 5, 2020
@ibrahimyilmaz ibrahimyilmaz changed the title Make DSL ViewBinding supported [kiel ]Make DSL ViewBinding supported Aug 6, 2020
@mirjalal
Copy link

You're gonna to consider DataBinding, aren't you?

@ibrahimyilmaz
Copy link
Owner Author

Hello @mirjalal,
Thank you for your interest in Kiel. Ofc DataBinding should be considered.
I created specific issue ticket for that. #47.
For data binding I am chasing how kiel can provide intiuitive syntax, so this is also the topic for data binding.
Because the invention new concept is good but explaining and teaching it is hard.

All issues/PR's are always welcome.

@ibrahimyilmaz ibrahimyilmaz added the help wanted Extra attention is needed label Aug 15, 2020
@mirjalal
Copy link

Hi @ibrahimyilmaz. Is it possible to put that functionality into another dependency? I meant, in case of if databinding and/or viewbinding feature(s) required, we could add them as additional dependency to our projoct OR it's also be nice that only binding related features implemented by default in this lib. Those are my thoughts.

@ibrahimyilmaz
Copy link
Owner Author

Hi @mirjalal

It makes really sense. Kiel probably have this in 1.2.0 or 1.3.0.

The main point is to find how kiel provides this more intuitive. How would you like to use it? I also ask other developers that I know.

Please add your suggestion or If you want to contribute with PR, please feel Free.

In this issue, we will evaluate the options and implement it together and better for us!

@ibrahimyilmaz
Copy link
Owner Author

In the version 1.1.0 we can do:

class MessageViewHolder(view: View) : RecyclerViewHolder<MessageListItemViewState>(view) {
    val binding = AdapterMessageListItemBinding.bind(view)
}

we can directly reach this binding in onBindViewHolder = {} it is also same for DataBinding.

I mean you can use ViewBinding and DataBinding as you use in Google's one till we may find good intuitive way for DSL definition.

My personal priority is on PagerAdapter atm. As I said if you want to contribute in that way. I will be very happy.

@mirjalal
Copy link

I've some ideas about that, lemme think about it a bit. If any, I will return w/ comment and/or PR as well.

@Ayushj045
Copy link

Sir kindly assign me this project . I would like to contribute in this project.

@ibrahimyilmaz
Copy link
Owner Author

Hey! You are free to implement. Fork and create your pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants