forked from phuang/ibus
-
Notifications
You must be signed in to change notification settings - Fork 174
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ui/gtk2: Deprecate gettext.bind_textdomain_codeset() since Python 3.8
setup/i18n.py is a symlink of ui/gtk2/i18n.py env PYTHONWARNINGS='d' ibus-setup BUG=#2276
- Loading branch information
Showing
1 changed file
with
7 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28acfd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fujiwarat!
I was about to apply this in Debian, since it seems a good idea to prevent a python3.10 issue. However, we are fetching the upstream source from https://github.com/ibus/ibus/releases, and there
setup/i18n.py
is a regular file and not a symlink. (ui/gtk2
does not exist.)So I got a bit confused. For now I applied this commit to
setup/i18n.py
directly.https://salsa.debian.org/debian/ibus/-/commit/8f0b70f0
28acfd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gunnarhj
Thank you for the attention note. Probably I think the patch is nice to have at the moment since Python does not output the debug message in the official releases by default.
FYI. There is another symlink issue:
https://desktopi18n.wordpress.com/2021/11/12/ibus-1-5-25-is-released/
28acfd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks for mentioning it. Coincidentally we apply that patch in Debian too. 😉 But in that case I had noticed your note in the commit message.