Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLS #2342

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Update URLS #2342

merged 1 commit into from
Sep 1, 2021

Conversation

ermshiperete
Copy link

IBus got moved to GitHub. This changes the remaining URLs that still pointed to the old site. Also fixed a typo.

@fujiwarat fujiwarat self-requested a review September 1, 2021 04:28
@fujiwarat
Copy link
Member

LGTM.
If you wish to attach your signature in your patch, please add a line of BUG=https://github.com/ibus/ibus/pull/2342 in your patch description

@fujiwarat
Copy link
Member

Also your master is a bit old against ibus/ibus master.

@ermshiperete
Copy link
Author

Also your master is a bit old against ibus/ibus master.

That I don't understand 😕 For me it shows being based on current master (at https://github.com/ibus/ibus) at the time the PR got created, which is also tag 1.5.25.

IBus got moved to GitHub. This changes the remaining URLs that
still pointed to the old site. Also fixed a typo.

BUG=ibus#2342
@fujiwarat
Copy link
Member

Thank you for your cooperation.

For me it shows being based on current master (at https://github.com/ibus/ibus) at the time

It was TRUE at that time and I integrated another patch after you created the PR. I'd like to merge patches without fuzzy commits and I asked your rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants