Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding artifact files to runs #215

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Support adding artifact files to runs #215

merged 1 commit into from
Oct 6, 2021

Conversation

john-dupuy
Copy link
Contributor

@john-dupuy john-dupuy commented Oct 1, 2021 •
edited
Loading

  • Add relationship between artifacts and runs in the DB
  • Add upgrade_3 DB upgrade function to support the new relationship
  • Support run_id in the controller and openapi spec
  • Show the artifacts in the frontend for the run details page

Example screenshot artifact I uploaded to a run:
Screenshot from 2021-10-01 13-49-04

@john-dupuy john-dupuy marked this pull request as draft October 1, 2021 20:27
@john-dupuy john-dupuy changed the title Artifacts on Runs Support adding artifact files to runs Oct 1, 2021
@john-dupuy john-dupuy added enhancement New feature or request backend frontend labels Oct 1, 2021
rsnyman
rsnyman approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@rsnyman rsnyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only change I might investigate is making a more generic getArtifacts() method that maybe takes a set of parameters as an argument, so that we can use the same logic in more than one place without duplicating the code.

For example:

getArtifacts(params) {
  fetch(buildUrl(Settings.serverUrl + '/artifact', params))
  ...
}

@john-dupuy
Copy link
Contributor Author

john-dupuy commented Oct 5, 2021 •
edited
Loading

Oh yeah that's a good idea, I can move it out to the utilities function. I'll work on that today.

Having some trouble figuring out all the async stuff with fetch, I can't seem to get the state to update correctly, will look into it tomorrow.

Edit: for the life of me, I can't figure this out. I played with various promises and fetches but cannot get them to resolve in the proper way. I'm going to keep it as is for now and leave this as a follow-up. @rsnyman you can probably tackle this one much more quickly than I can.

@john-dupuy john-dupuy marked this pull request as ready for review October 6, 2021 17:23
@john-dupuy john-dupuy merged commit 5e8e4d3 into ibutsu:master Oct 6, 2021
@john-dupuy john-dupuy mentioned this pull request Oct 15, 2021
Merged
rsnyman added a commit to rsnyman/ibutsu-server that referenced this pull request Jan 18, 2022
@rsnyman
Release 2.0.0\n\n* Estimate count on test-history page
3183ed2 
* Small improvements to the test history tab
* Hide username/password related components when user login is disabled (ibutsu#279)
* Add test history tab to Result page (ibutsu#276)
* Address some issues raised by static analysis (ibutsu#278)
* Convert USER_LOGIN_ENABLED to bool if given as env var
* Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272)
* Add a way to disabled basic auth for non-superadmins
* Add get_user_list endpoint
* Fix keycloak login (ibutsu#270)
* Update docker image names (ibutsu#267)
* Show login progress feedback (ibutsu#266)
* Add build_deploy script for App-SRE builds (ibutsu#265)
* A single jUnit XML file is a single test run, refactor the importer to take this into account
* Some code refactoring after static analysis. (ibutsu#245)
* Implement MetaFilter with separate field and value (ibutsu#225)
* Adjustments for app-sre deployment (ibutsu#256)
* Fix small FE bug on user profile page
* Add superadmin user after upgrading db
* Add a task for adding users/project owners
* Add superadmin to the ocp template files
* Add ability to create superadmin user on startup
* Allow logging in by hitting 'Enter'
* Require superadmin token for running admin task
* Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247)
* Some small fixes to ENV vars
* Split templates into one file for each
* Update @greatsumini/react-facebook-login
* Fix Jenkins Job View
* Allow superadmins to update projects
* Support adding users to projects
* Add project info to the profile page
* Filter runs/results on user projects, if none specified
* Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234)
* Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233)
* Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232)
* Add authentication and authorisation to Ibutsu
* Promote user property data to metadata
* Add babel core dependency
* Switch from 'babel-eslint' to '@babel/eslint-parser'
* Update and re-apply pre-commit (ibutsu#216)
* Support adding artifacts to test runs (ibutsu#215)
@rsnyman rsnyman mentioned this pull request Jan 18, 2022
Merged
jjaquish pushed a commit to jjaquish/ibutsu-server that referenced this pull request Aug 9, 2022
@john-dupuy @jjaquish
Support adding artifacts to test runs (ibutsu#215)
8b16399
jjaquish pushed a commit to jjaquish/ibutsu-server that referenced this pull request Aug 9, 2022
@rsnyman @jjaquish
Release 2.0.0\n\n* Estimate count on test-history page
1afda61 
* Small improvements to the test history tab
* Hide username/password related components when user login is disabled (ibutsu#279)
* Add test history tab to Result page (ibutsu#276)
* Address some issues raised by static analysis (ibutsu#278)
* Convert USER_LOGIN_ENABLED to bool if given as env var
* Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272)
* Add a way to disabled basic auth for non-superadmins
* Add get_user_list endpoint
* Fix keycloak login (ibutsu#270)
* Update docker image names (ibutsu#267)
* Show login progress feedback (ibutsu#266)
* Add build_deploy script for App-SRE builds (ibutsu#265)
* A single jUnit XML file is a single test run, refactor the importer to take this into account
* Some code refactoring after static analysis. (ibutsu#245)
* Implement MetaFilter with separate field and value (ibutsu#225)
* Adjustments for app-sre deployment (ibutsu#256)
* Fix small FE bug on user profile page
* Add superadmin user after upgrading db
* Add a task for adding users/project owners
* Add superadmin to the ocp template files
* Add ability to create superadmin user on startup
* Allow logging in by hitting 'Enter'
* Require superadmin token for running admin task
* Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247)
* Some small fixes to ENV vars
* Split templates into one file for each
* Update @greatsumini/react-facebook-login
* Fix Jenkins Job View
* Allow superadmins to update projects
* Support adding users to projects
* Add project info to the profile page
* Filter runs/results on user projects, if none specified
* Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234)
* Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233)
* Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232)
* Add authentication and authorisation to Ibutsu
* Promote user property data to metadata
* Add babel core dependency
* Switch from 'babel-eslint' to '@babel/eslint-parser'
* Update and re-apply pre-commit (ibutsu#216)
* Support adding artifacts to test runs (ibutsu#215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsnyman rsnyman rsnyman approved these changes

Assignees
No one assigned
Labels
backend enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@john-dupuy @rsnyman