Show login progress feedback #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsnyman
commented
Dec 9, 2021
rsnyman
commented
- Add a spinner to the login button so that people can see that something is happening
- Add a spinner to the login button so that people can see that something is happening
john-dupuy
approved these changes
Dec 9, 2021
|
Nice - that's slick! |
rsnyman
added a commit
to rsnyman/ibutsu-server
that referenced
this pull request
Jan 18, 2022
* Small improvements to the test history tab * Hide username/password related components when user login is disabled (ibutsu#279) * Add test history tab to Result page (ibutsu#276) * Address some issues raised by static analysis (ibutsu#278) * Convert USER_LOGIN_ENABLED to bool if given as env var * Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272) * Add a way to disabled basic auth for non-superadmins * Add get_user_list endpoint * Fix keycloak login (ibutsu#270) * Update docker image names (ibutsu#267) * Show login progress feedback (ibutsu#266) * Add build_deploy script for App-SRE builds (ibutsu#265) * A single jUnit XML file is a single test run, refactor the importer to take this into account * Some code refactoring after static analysis. (ibutsu#245) * Implement MetaFilter with separate field and value (ibutsu#225) * Adjustments for app-sre deployment (ibutsu#256) * Fix small FE bug on user profile page * Add superadmin user after upgrading db * Add a task for adding users/project owners * Add superadmin to the ocp template files * Add ability to create superadmin user on startup * Allow logging in by hitting 'Enter' * Require superadmin token for running admin task * Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247) * Some small fixes to ENV vars * Split templates into one file for each * Update @greatsumini/react-facebook-login * Fix Jenkins Job View * Allow superadmins to update projects * Support adding users to projects * Add project info to the profile page * Filter runs/results on user projects, if none specified * Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234) * Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233) * Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232) * Add authentication and authorisation to Ibutsu * Promote user property data to metadata * Add babel core dependency * Switch from 'babel-eslint' to '@babel/eslint-parser' * Update and re-apply pre-commit (ibutsu#216) * Support adding artifacts to test runs (ibutsu#215)
Merged
jjaquish
pushed a commit
to jjaquish/ibutsu-server
that referenced
this pull request
Aug 9, 2022
- Add a spinner to the login button so that people can see that something is happening
jjaquish
pushed a commit
to jjaquish/ibutsu-server
that referenced
this pull request
Aug 9, 2022
* Small improvements to the test history tab * Hide username/password related components when user login is disabled (ibutsu#279) * Add test history tab to Result page (ibutsu#276) * Address some issues raised by static analysis (ibutsu#278) * Convert USER_LOGIN_ENABLED to bool if given as env var * Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272) * Add a way to disabled basic auth for non-superadmins * Add get_user_list endpoint * Fix keycloak login (ibutsu#270) * Update docker image names (ibutsu#267) * Show login progress feedback (ibutsu#266) * Add build_deploy script for App-SRE builds (ibutsu#265) * A single jUnit XML file is a single test run, refactor the importer to take this into account * Some code refactoring after static analysis. (ibutsu#245) * Implement MetaFilter with separate field and value (ibutsu#225) * Adjustments for app-sre deployment (ibutsu#256) * Fix small FE bug on user profile page * Add superadmin user after upgrading db * Add a task for adding users/project owners * Add superadmin to the ocp template files * Add ability to create superadmin user on startup * Allow logging in by hitting 'Enter' * Require superadmin token for running admin task * Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247) * Some small fixes to ENV vars * Split templates into one file for each * Update @greatsumini/react-facebook-login * Fix Jenkins Job View * Allow superadmins to update projects * Support adding users to projects * Add project info to the profile page * Filter runs/results on user projects, if none specified * Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234) * Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233) * Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232) * Add authentication and authorisation to Ibutsu * Promote user property data to metadata * Add babel core dependency * Switch from 'babel-eslint' to '@babel/eslint-parser' * Update and re-apply pre-commit (ibutsu#216) * Support adding artifacts to test runs (ibutsu#215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.