-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test history tab to Result page #276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8ed19e
to
9ebde32
Compare
9ebde32
to
e61d44a
Compare
rsnyman
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rsnyman
added a commit
to rsnyman/ibutsu-server
that referenced
this pull request
Jan 18, 2022
* Small improvements to the test history tab * Hide username/password related components when user login is disabled (ibutsu#279) * Add test history tab to Result page (ibutsu#276) * Address some issues raised by static analysis (ibutsu#278) * Convert USER_LOGIN_ENABLED to bool if given as env var * Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272) * Add a way to disabled basic auth for non-superadmins * Add get_user_list endpoint * Fix keycloak login (ibutsu#270) * Update docker image names (ibutsu#267) * Show login progress feedback (ibutsu#266) * Add build_deploy script for App-SRE builds (ibutsu#265) * A single jUnit XML file is a single test run, refactor the importer to take this into account * Some code refactoring after static analysis. (ibutsu#245) * Implement MetaFilter with separate field and value (ibutsu#225) * Adjustments for app-sre deployment (ibutsu#256) * Fix small FE bug on user profile page * Add superadmin user after upgrading db * Add a task for adding users/project owners * Add superadmin to the ocp template files * Add ability to create superadmin user on startup * Allow logging in by hitting 'Enter' * Require superadmin token for running admin task * Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247) * Some small fixes to ENV vars * Split templates into one file for each * Update @greatsumini/react-facebook-login * Fix Jenkins Job View * Allow superadmins to update projects * Support adding users to projects * Add project info to the profile page * Filter runs/results on user projects, if none specified * Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234) * Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233) * Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232) * Add authentication and authorisation to Ibutsu * Promote user property data to metadata * Add babel core dependency * Switch from 'babel-eslint' to '@babel/eslint-parser' * Update and re-apply pre-commit (ibutsu#216) * Support adding artifacts to test runs (ibutsu#215)
Merged
jjaquish
pushed a commit
to jjaquish/ibutsu-server
that referenced
this pull request
Aug 9, 2022
* Add test history tab to Result page * Get rid of buggy Tooltip
jjaquish
pushed a commit
to jjaquish/ibutsu-server
that referenced
this pull request
Aug 9, 2022
* Small improvements to the test history tab * Hide username/password related components when user login is disabled (ibutsu#279) * Add test history tab to Result page (ibutsu#276) * Address some issues raised by static analysis (ibutsu#278) * Convert USER_LOGIN_ENABLED to bool if given as env var * Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272) * Add a way to disabled basic auth for non-superadmins * Add get_user_list endpoint * Fix keycloak login (ibutsu#270) * Update docker image names (ibutsu#267) * Show login progress feedback (ibutsu#266) * Add build_deploy script for App-SRE builds (ibutsu#265) * A single jUnit XML file is a single test run, refactor the importer to take this into account * Some code refactoring after static analysis. (ibutsu#245) * Implement MetaFilter with separate field and value (ibutsu#225) * Adjustments for app-sre deployment (ibutsu#256) * Fix small FE bug on user profile page * Add superadmin user after upgrading db * Add a task for adding users/project owners * Add superadmin to the ocp template files * Add ability to create superadmin user on startup * Allow logging in by hitting 'Enter' * Require superadmin token for running admin task * Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247) * Some small fixes to ENV vars * Split templates into one file for each * Update @greatsumini/react-facebook-login * Fix Jenkins Job View * Allow superadmins to update projects * Support adding users to projects * Add project info to the profile page * Filter runs/results on user projects, if none specified * Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234) * Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233) * Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232) * Add authentication and authorisation to Ibutsu * Promote user property data to metadata * Add babel core dependency * Switch from 'babel-eslint' to '@babel/eslint-parser' * Update and re-apply pre-commit (ibutsu#216) * Support adding artifacts to test runs (ibutsu#215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test result history tab to the
ResultView
. This page contains the following:It looks like this:
![Screenshot from 2022-01-13 14-23-36](https://user-images.githubusercontent.com/44065123/149418613-31e09d27-a2b9-4aab-91be-a5f035699ce5.png)
It is also possible to view this page within the classify-failures page of a run:
![Screenshot from 2022-01-13 14-25-18](https://user-images.githubusercontent.com/44065123/149418722-eaf23ade-7b69-4658-917a-5a8638197215.png)
I also introduce lazy-loading of the
ResultView
on table expansion for both this page and theclassify-failures
page. It's largely based on: patternfly/patternfly-react#1450Especially for failed tests, one potential enhancement would be to show the date the test last passed.
This work is for: https://issues.redhat.com/browse/IBUTSU-64