Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test history tab to Result page #276

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

john-dupuy
Copy link
Contributor

@john-dupuy john-dupuy commented Jan 12, 2022

Adding a test result history tab to the ResultView. This page contains the following:

  • Dropdown to select a date range (1 Week, 2 Weeks, 1 Month, 2 Months, 3 Months, 5 Months) from which to view the test's history
  • Quick filter to view only failed/error results
  • Small summary of passed/failed/error given the date range (note this ignores the quick filter for only viewing failed/error results)
  • Table of historical results

It looks like this:
Screenshot from 2022-01-13 14-23-36

It is also possible to view this page within the classify-failures page of a run:
Screenshot from 2022-01-13 14-25-18

I also introduce lazy-loading of the ResultView on table expansion for both this page and the classify-failures page. It's largely based on: patternfly/patternfly-react#1450

Especially for failed tests, one potential enhancement would be to show the date the test last passed.

This work is for: https://issues.redhat.com/browse/IBUTSU-64

@john-dupuy john-dupuy added enhancement New feature or request frontend labels Jan 12, 2022
@john-dupuy john-dupuy marked this pull request as draft January 12, 2022 22:10
@john-dupuy john-dupuy marked this pull request as ready for review January 13, 2022 22:21
@john-dupuy john-dupuy changed the title Draft: Add test history tab to Result page Add test history tab to Result page Jan 13, 2022
Copy link
Contributor

@rsnyman rsnyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-dupuy john-dupuy merged commit c8fef18 into ibutsu:master Jan 14, 2022
rsnyman added a commit to rsnyman/ibutsu-server that referenced this pull request Jan 18, 2022
* Small improvements to the test history tab
* Hide username/password related components when user login is disabled (ibutsu#279)
* Add test history tab to Result page (ibutsu#276)
* Address some issues raised by static analysis (ibutsu#278)
* Convert USER_LOGIN_ENABLED to bool if given as env var
* Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272)
* Add a way to disabled basic auth for non-superadmins
* Add get_user_list endpoint
* Fix keycloak login (ibutsu#270)
* Update docker image names (ibutsu#267)
* Show login progress feedback (ibutsu#266)
* Add build_deploy script for App-SRE builds (ibutsu#265)
* A single jUnit XML file is a single test run, refactor the importer to take this into account
* Some code refactoring after static analysis. (ibutsu#245)
* Implement MetaFilter with separate field and value (ibutsu#225)
* Adjustments for app-sre deployment (ibutsu#256)
* Fix small FE bug on user profile page
* Add superadmin user after upgrading db
* Add a task for adding users/project owners
* Add superadmin to the ocp template files
* Add ability to create superadmin user on startup
* Allow logging in by hitting 'Enter'
* Require superadmin token for running admin task
* Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247)
* Some small fixes to ENV vars
* Split templates into one file for each
* Update @greatsumini/react-facebook-login
* Fix Jenkins Job View
* Allow superadmins to update projects
* Support adding users to projects
* Add project info to the profile page
* Filter runs/results on user projects, if none specified
* Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234)
* Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233)
* Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232)
* Add authentication and authorisation to Ibutsu
* Promote user property data to metadata
* Add babel core dependency
* Switch from 'babel-eslint' to '@babel/eslint-parser'
* Update and re-apply pre-commit (ibutsu#216)
* Support adding artifacts to test runs (ibutsu#215)
@rsnyman rsnyman mentioned this pull request Jan 18, 2022
jjaquish pushed a commit to jjaquish/ibutsu-server that referenced this pull request Aug 9, 2022
* Add test history tab to Result page

* Get rid of buggy Tooltip
jjaquish pushed a commit to jjaquish/ibutsu-server that referenced this pull request Aug 9, 2022
* Small improvements to the test history tab
* Hide username/password related components when user login is disabled (ibutsu#279)
* Add test history tab to Result page (ibutsu#276)
* Address some issues raised by static analysis (ibutsu#278)
* Convert USER_LOGIN_ENABLED to bool if given as env var
* Get a user's primary e-mail on GitHub if they have no public e-mail address (ibutsu#272)
* Add a way to disabled basic auth for non-superadmins
* Add get_user_list endpoint
* Fix keycloak login (ibutsu#270)
* Update docker image names (ibutsu#267)
* Show login progress feedback (ibutsu#266)
* Add build_deploy script for App-SRE builds (ibutsu#265)
* A single jUnit XML file is a single test run, refactor the importer to take this into account
* Some code refactoring after static analysis. (ibutsu#245)
* Implement MetaFilter with separate field and value (ibutsu#225)
* Adjustments for app-sre deployment (ibutsu#256)
* Fix small FE bug on user profile page
* Add superadmin user after upgrading db
* Add a task for adding users/project owners
* Add superadmin to the ocp template files
* Add ability to create superadmin user on startup
* Allow logging in by hitting 'Enter'
* Require superadmin token for running admin task
* Update pods script to create an admin user, a project, standardise on echo, and make the output prettier. (ibutsu#247)
* Some small fixes to ENV vars
* Split templates into one file for each
* Update @greatsumini/react-facebook-login
* Fix Jenkins Job View
* Allow superadmins to update projects
* Support adding users to projects
* Add project info to the profile page
* Filter runs/results on user projects, if none specified
* Bump url-parse from 1.5.1 to 1.5.3 in /frontend (ibutsu#234)
* Bump tmpl from 1.0.4 to 1.0.5 in /frontend (ibutsu#233)
* Bump tar from 6.1.0 to 6.1.11 in /frontend (ibutsu#232)
* Add authentication and authorisation to Ibutsu
* Promote user property data to metadata
* Add babel core dependency
* Switch from 'babel-eslint' to '@babel/eslint-parser'
* Update and re-apply pre-commit (ibutsu#216)
* Support adding artifacts to test runs (ibutsu#215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants